Skip to content

Spherical RoPE#2082

Open
csjfwang wants to merge 67 commits intoecmwf:developfrom
csjfwang:spherical-rope
Open

Spherical RoPE#2082
csjfwang wants to merge 67 commits intoecmwf:developfrom
csjfwang:spherical-rope

Conversation

@csjfwang
Copy link
Copy Markdown
Contributor

Description

1st draft version of spherical rope.

Issue Number

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

wang85 and others added 30 commits July 16, 2025 10:07
@csjfwang csjfwang marked this pull request as draft March 19, 2026 10:22
@github-actions github-actions Bot added the model Related to model training or definition (not generic infra) label Mar 19, 2026
Jifeng Wang and others added 4 commits March 24, 2026 21:14
@csjfwang csjfwang marked this pull request as ready for review April 25, 2026 20:17
@csjfwang csjfwang changed the title [Draft] Spherical rope Spherical RoPE Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:pretrain model Related to model training or definition (not generic infra)

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants