Skip to content

ECC-2236: Feature/sparky#436

Open
rdosinski wants to merge 14 commits intohotfix/2.46.1from
feature/sparky
Open

ECC-2236: Feature/sparky#436
rdosinski wants to merge 14 commits intohotfix/2.46.1from
feature/sparky

Conversation

@rdosinski
Copy link
Collaborator

Description

This branch refactors the way the fire data are encoded and archived in MARS. It follows the developments done for hydrological data.

It introduces a new more general post processing entry 'fire model', a modelName for the geff and sparky fire models with corresponding versioning. The forcing key with the values defined for hydrology are reused to distinguish between operational forecast and ERA5 driven fire models. It is post-mtg2 with the timespan key as some of the fire parameters are daily products.

For backwards compatibility the old typeOfPostProcessing=10 behaviour is still present.

More details can be found in the JIRA issue ECC-2236.

Please merge the branch to hotfix/2.46.1 and the develop branch.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (hotfix/2.46.1@236279f). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             hotfix/2.46.1     #436   +/-   ##
================================================
  Coverage                 ?   88.51%           
================================================
  Files                    ?      849           
  Lines                    ?    63104           
  Branches                 ?    11226           
================================================
  Hits                     ?    55856           
  Misses                   ?     7248           
  Partials                 ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joobog joobog added the approved-for-ci Approved to run CI on ECMWF machines label Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-for-ci Approved to run CI on ECMWF machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants