Skip to content

Docs/fdb 504 envvar#230

Draft
ChrisspyB wants to merge 3 commits intodevelopfrom
docs/FDB-504-envvar
Draft

Docs/fdb 504 envvar#230
ChrisspyB wants to merge 3 commits intodevelopfrom
docs/FDB-504-envvar

Conversation

@ChrisspyB
Copy link
Copy Markdown
Member

@ChrisspyB ChrisspyB commented Feb 19, 2026

Description

Depends on #229.

Does the following:

  • Adds env var FDB_SUB_TOCS which from now should be preferred over FDB5_SUB_TOCS.
  • Removed the var FDB5_SKIP_REMOTE_PROTOCOL_SANITY_CHECK and related code.
    • Because I do not believe there is a reason to not validate the protocol versions being used.
  • Added some documentation to FDB_SUB_TOCS.
    • These ought to link to a more general discussion about tocs, subtocs and the POSIX backend to FDB in general, if such a page exists.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation Z3FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/z3fdb/pull-requests/PR-230

🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-230

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.33%. Comparing base (b15d11d) to head (ced618f).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/fdb5/LibFdb5.cc 16.66% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #230   +/-   ##
========================================
  Coverage    71.33%   71.33%           
========================================
  Files          376      376           
  Lines        23757    23754    -3     
  Branches      2478     2478           
========================================
- Hits         16947    16946    -1     
+ Misses        6810     6808    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danovaro danovaro force-pushed the docs/FDB-504-envvar branch from 8e64b97 to ced618f Compare March 6, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants