Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Python packaging/wheel metadata for pyfdb (via a staged setup.cfg generated by CMake) and standardizes test-file licensing by adding ECMWF Apache 2.0 headers across the tests/pyfdb/integration suite.
Changes:
- Generate a
setup.cfginto the pyfdb wheel staging directory to enrich PyPI wheel metadata (name/description/URLs/license/extras). - Add ECMWF Apache 2.0 license headers to pyfdb integration tests (plus small formatting-only changes).
- Add the same license header to
src/pyfdb/_internal/pyfdb_internal.py.
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/pyfdb/integration/test_wipe.py | Adds license header; minor formatting of asserts/prints. |
| tests/pyfdb/integration/test_wildcard_selection.py | Adds license header; minor formatting for readability. |
| tests/pyfdb/integration/test_uri.py | Adds license header; minor string formatting adjustments. |
| tests/pyfdb/integration/test_types.py | Adds license header only. |
| tests/pyfdb/integration/test_status.py | Adds license header only. |
| tests/pyfdb/integration/test_stats.py | Adds license header only. |
| tests/pyfdb/integration/test_selection_mapper.py | Adds license header only. |
| tests/pyfdb/integration/test_retrieve.py | Adds license header only. |
| tests/pyfdb/integration/test_purge.py | Adds license header only. |
| tests/pyfdb/integration/test_list.py | Adds license header only. |
| tests/pyfdb/integration/test_inspect.py | Adds license header only. |
| tests/pyfdb/integration/test_fdb.py | Adds license header; minor formatting of long lines. |
| tests/pyfdb/integration/test_fdb_tool_request.py | Adds license header only. |
| tests/pyfdb/integration/test_data_handle.py | Adds license header only. |
| tests/pyfdb/integration/test_control.py | Adds license header; minor formatting of long expressions. |
| tests/pyfdb/integration/test_control_enums.py | Adds license header; minor formatting of long asserts. |
| tests/pyfdb/integration/test_config.py | Adds license header only. |
| tests/pyfdb/integration/test_config_mapper.py | Adds license header; minor formatting of a long call. |
| tests/pyfdb/integration/test_backward_comp.py | Adds license header only. |
| tests/pyfdb/integration/test_archive.py | Adds license header only. |
| tests/pyfdb/conftest.py | Updates copyright year; minor formatting. |
| src/pyfdb/_internal/pyfdb_internal.py | Adds license header; minor formatting. |
| src/CMakeLists.txt | Stages setup.cfg for pyfdb wheel generation. |
| cmake/pyfdb_setup.cfg.in | Introduces richer wheel metadata and extras for pyfdb. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8de55e5 to
cccc379
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #260 +/- ##
===========================================
- Coverage 71.22% 71.21% -0.01%
===========================================
Files 376 376
Lines 23762 23762
Branches 2478 2479 +1
===========================================
- Hits 16924 16923 -1
- Misses 6838 6839 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ef36282 to
a8423a1
Compare
a8423a1 to
0db3924
Compare
e36535a to
48d6e72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added metadata for pypi wheel creation and license header for test files.
Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-260