Skip to content

Hotfix/pyfdb wheel metadata#260

Open
tbkr wants to merge 5 commits intodevelopfrom
hotfix/pyfdb-wheel-metadata
Open

Hotfix/pyfdb wheel metadata#260
tbkr wants to merge 5 commits intodevelopfrom
hotfix/pyfdb-wheel-metadata

Conversation

@tbkr
Copy link
Copy Markdown
Contributor

@tbkr tbkr commented Mar 31, 2026

Description

Added metadata for pypi wheel creation and license header for test files.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation FDB 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/fdb/pull-requests/PR-260

@tbkr tbkr requested a review from Copilot March 31, 2026 12:48
@tbkr tbkr marked this pull request as ready for review March 31, 2026 12:52
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Python packaging/wheel metadata for pyfdb (via a staged setup.cfg generated by CMake) and standardizes test-file licensing by adding ECMWF Apache 2.0 headers across the tests/pyfdb/integration suite.

Changes:

  • Generate a setup.cfg into the pyfdb wheel staging directory to enrich PyPI wheel metadata (name/description/URLs/license/extras).
  • Add ECMWF Apache 2.0 license headers to pyfdb integration tests (plus small formatting-only changes).
  • Add the same license header to src/pyfdb/_internal/pyfdb_internal.py.

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/pyfdb/integration/test_wipe.py Adds license header; minor formatting of asserts/prints.
tests/pyfdb/integration/test_wildcard_selection.py Adds license header; minor formatting for readability.
tests/pyfdb/integration/test_uri.py Adds license header; minor string formatting adjustments.
tests/pyfdb/integration/test_types.py Adds license header only.
tests/pyfdb/integration/test_status.py Adds license header only.
tests/pyfdb/integration/test_stats.py Adds license header only.
tests/pyfdb/integration/test_selection_mapper.py Adds license header only.
tests/pyfdb/integration/test_retrieve.py Adds license header only.
tests/pyfdb/integration/test_purge.py Adds license header only.
tests/pyfdb/integration/test_list.py Adds license header only.
tests/pyfdb/integration/test_inspect.py Adds license header only.
tests/pyfdb/integration/test_fdb.py Adds license header; minor formatting of long lines.
tests/pyfdb/integration/test_fdb_tool_request.py Adds license header only.
tests/pyfdb/integration/test_data_handle.py Adds license header only.
tests/pyfdb/integration/test_control.py Adds license header; minor formatting of long expressions.
tests/pyfdb/integration/test_control_enums.py Adds license header; minor formatting of long asserts.
tests/pyfdb/integration/test_config.py Adds license header only.
tests/pyfdb/integration/test_config_mapper.py Adds license header; minor formatting of a long call.
tests/pyfdb/integration/test_backward_comp.py Adds license header only.
tests/pyfdb/integration/test_archive.py Adds license header only.
tests/pyfdb/conftest.py Updates copyright year; minor formatting.
src/pyfdb/_internal/pyfdb_internal.py Adds license header; minor formatting.
src/CMakeLists.txt Stages setup.cfg for pyfdb wheel generation.
cmake/pyfdb_setup.cfg.in Introduces richer wheel metadata and extras for pyfdb.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tbkr tbkr force-pushed the hotfix/pyfdb-wheel-metadata branch from 8de55e5 to cccc379 Compare March 31, 2026 13:32
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.21%. Comparing base (b0b777b) to head (48d6e72).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #260      +/-   ##
===========================================
- Coverage    71.22%   71.21%   -0.01%     
===========================================
  Files          376      376              
  Lines        23762    23762              
  Branches      2478     2479       +1     
===========================================
- Hits         16924    16923       -1     
- Misses        6838     6839       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tbkr tbkr force-pushed the hotfix/pyfdb-wheel-metadata branch from ef36282 to a8423a1 Compare April 1, 2026 11:25
@tbkr tbkr force-pushed the hotfix/pyfdb-wheel-metadata branch from a8423a1 to 0db3924 Compare April 2, 2026 14:12
@tbkr tbkr force-pushed the hotfix/pyfdb-wheel-metadata branch from e36535a to 48d6e72 Compare April 2, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants