Fix and improve local contract address handling #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move address files to addresses/templates/ (committed to git) - Add addresses/local/ for working copies (gitignored) - Add init-addresses service to copy templates on startup - Update all volume mounts to use addresses/local/ - Fix graph-contracts to add legacy contracts without breaking volume mounts - Add scripts/clean.sh for easy environment cleanup This ensures address files are properly initialized and managed across container rebuilds, and fixes the gateway crash due to missing legacy contract fields.
- Move config files to config/templates/ (committed to git) - Add config/local/ for working copies (gitignored) - Add init-addresses service to copy templates on startup - Update all volume mounts to use config/local/ - Fix graph-contracts to add legacy contracts without breaking volume mounts - Add scripts/clean.sh for easy environment cleanup This ensures config files are properly initialized and managed across container rebuilds, and fixes the gateway crash due to missing legacy contract fields.
- Add comprehensive README documenting config file management - Rename init-addresses service to init-config (more accurate) - Add user: "1000" to init-config for consistent permissions - Document file relationships, mount points, and cleaning procedures
RembrandtK
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gateway service was failiing to start due to missing LegacyServiceRegistry and LegacyDisputeManager entries in subgraph-service.json.
There was an attempt to patch them in
graph-contracts/run.sh, however this appeared to not be updating the shared file. There were also address files checked into Git that were not relevant and created unnecessary and irrelevant changes to tracked files.In the process of investigating and resloving I made these suggested changes to the way addresses are handled, and made some miscellaneous associated changes:
config/templates/(committed to git)init-configservice to runconfig/create-local-config-files.shduringdocker compose upscripts/clean.shfor easy environment cleanup