Repository navigation
Conversation
cpp977
force-pushed
the
master
branch
3 times, most recently
from
October 28, 2026 07:12
92c96f5 to
a8838a6
Compare
Author
|
I fixed the failing integration tests and rebased against upstream. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #672.
I validated the behavior of the test by sending one example prompt via curl with and without the merge of assistant turns and the renaming of
tool-callstotool_calls. I got roughly 75% successful tool call requests from the model for the old case and 100% successful tool call requests for the fix.Tests pass for me for the file, I changed. However, I get one unrelated error:
which I expect to be there due to a setup issue on my side.