Skip to content

Conversation

@dyatko
Copy link

@dyatko dyatko commented Jul 17, 2018

No description provided.

@alexilyaev
Copy link

@eduardbcom If this package would work with Node v8, this PR would be very much appreciated.

@rochdev
Copy link

rochdev commented Aug 10, 2018

@dyatko Why not go even lower? Since this is a fork of the original memwatch, it should support as low as 0.8.0.

@dyatko
Copy link
Author

dyatko commented Aug 10, 2018

@rochdev I have no clue.
I just needed to get it to work with Node.js 8, which is the current LTS.

@rochdev
Copy link

rochdev commented Aug 10, 2018

@dyatko Fair enough :) BTW I found this one that is already updated: https://www.npmjs.com/package/@airbnb/node-memwatch

@nmccready
Copy link

What is going on with this ? yarn --ignore-engines seems to prove that this works fine with 8.X .

@nmccready
Copy link

Is there something in particular that possibly makes it not work with 8.X? Also, one big downside of @airbnb's fork is the loss of leak (leak event) detection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants