Fix: Call check_expired_dcc() every second to honor -timeout settings #1853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelortmann
changed the title
michaelortmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: https://github.com/michaelortmann
Patch by: https://github.com/michaelortmann
Fixes:
One-line summary:
Call
check_expired_dcc()every second to honor-timeoutsettingsAdditional description (if needed):
This bug is ancient
While at it, i made
eof_timeout_dcc_ident()staticTest cases demonstrating functionality (if applicable):
set ident-timeout 3Configure your machine/network, so that ident requests of the bot will time out
Then telnet to the bot
check_expired_dcc()is executed every 10 seconds, so you will notice that the timeout will be longer than 3 seconds depending on the gap between the start of the timeout and the start of thecheck_expired_dcc()cycle