docs(wiki): sync egg bundler runtime notes#5941
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis pull request updates wiki documentation to record egg-bundler runtime asset syncing, import.meta patching, module.yml bundle configuration and alias resolution rules, tegg manifest path normalization, and the runtime loader's global module loader check. A changelog entry and package documentation page were modified. Changesegg-bundler Documentation Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for the egg-bundler package, specifically recording changes related to runtime asset copying, module.yml configuration for aliases, and tegg manifest path normalization. It also documents the use of a global bundle module loader in LoaderUtil. I have no feedback to provide as there were no review comments to assess.
Deploying egg with
|
| Latest commit: |
9a8a549
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a26d0f31.egg-cci.pages.dev |
| Branch Preview URL: | https://agent-egg-doc-299983bd.egg-cci.pages.dev |
There was a problem hiding this comment.
Pull request overview
Updates the Egg Bundler wiki documentation to reflect current runtime behavior around bundle configuration, runtime asset copying, and tegg manifest/runtime integration, and records the sync in the wiki maintenance log.
Changes:
- Document
module.ymlsupport forbundle.pack.resolve.aliasandbundle.runtimeAssetsand how it merges/overrides programmatic config. - Document runtime asset copy behavior (default roots, force-copy dirs, and exclusions).
- Document tegg manifest path normalization and tegg runtime loader behavior (
globalThis.__EGG_BUNDLE_MODULE_LOADER__), and append a correspondingwiki/log.mdentry.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
wiki/packages/egg-bundler.md |
Syncs runtime notes: module.yml bundle config, runtime asset copying, and tegg manifest/loader integration. |
wiki/log.md |
Adds a dated log entry recording the bundler wiki sync and the primary sources referenced. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@wiki/packages/egg-bundler.md`:
- Around line 69-73: Update the documentation text in the egg-bundler package so
the compound adjective is hyphenated: change "tegg decorated files" to
"tegg-decorated files" in the sentence describing ManifestLoader normalizing
moduleReferences[].path and moduleDescriptors[].unitPath and the runtime note
about tegg's LoaderUtil checking globalThis.__EGG_BUNDLE_MODULE_LOADER__ before
falling back to import().
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 97a0bc87-b6a3-433d-9eaf-ff0ac013799d
📒 Files selected for processing (2)
wiki/log.mdwiki/packages/egg-bundler.md
Deploying egg-v3 with
|
| Latest commit: |
9a8a549
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://126c10cc.egg-v3.pages.dev |
| Branch Preview URL: | https://agent-egg-doc-299983bd.egg-v3.pages.dev |
Summary
Verification
git diff --checkpnpm exec oxfmt --check wiki/packages/egg-bundler.md wiki/log.mdcould not run because this checkout has no node_modules andoxfmtis not installed.Summary by CodeRabbit