docs(core): document loaderFS option#5948
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe ChangesLoaderFS Documentation Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in packages/core/README.md to include the new loaderFS option within LoaderOptions, which allows for custom filesystem implementations. The review feedback suggests improving the documentation's structure by moving the detailed explanation closer to the options table and refining the description of the default value for better technical accuracy.
There was a problem hiding this comment.
Pull request overview
Documents the new loaderFS hook on loader options in @eggjs/core, helping advanced integrations provide a custom filesystem/glob/loadFile implementation while keeping a clear default (RealLoaderFS).
Changes:
- Add prose documentation explaining
LoaderOptions.loaderFS,LoaderFS, and the defaultRealLoaderFS. - Add
loaderFSto theLoaderOptionsparameter table inpackages/core/README.md.
Deploying egg with
|
| Latest commit: |
5be779f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://31fff60b.egg-cci.pages.dev |
| Branch Preview URL: | https://egg-doc-loaderfs-readme-2026.egg-cci.pages.dev |
Deploying egg-v3 with
|
| Latest commit: |
5be779f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3bb7aaaf.egg-v3.pages.dev |
| Branch Preview URL: | https://egg-doc-loaderfs-readme-2026.egg-v3.pages.dev |
Summary
loaderFSLoaderOptions hook inpackages/core/README.mdLoaderFSand per-call options default to the current loader'sloaderFSloaderFSprose underLoaderOptionsand fix the markdown table columns/default glob textVerification
git diff --checkpnpm dlx oxfmt@0.46.0 --check packages/core/README.mdSummary by CodeRabbit
loaderFSoption: its required interface, defaulting toRealLoaderFS, and thatloaderFSis reused by load-to-app/context operations when omitted. Updated the LoaderOptions parameter table to reflect this behavior.