#381: Added options styleInjectRelativePath to allow module import for ESM libraries#395
Open
mummybot wants to merge 2 commits intoegoist:masterfrom
Open
#381: Added options styleInjectRelativePath to allow module import for ESM libraries#395mummybot wants to merge 2 commits intoegoist:masterfrom
mummybot wants to merge 2 commits intoegoist:masterfrom
Conversation
…ort for ESM libraries
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #395 +/- ##
==========================================
+ Coverage 92.94% 92.98% +0.04%
==========================================
Files 10 10
Lines 326 328 +2
Branches 115 116 +1
==========================================
+ Hits 303 305 +2
Misses 22 22
Partials 1 1 ☔ View full report in Codecov by Sentry. |
marselbairam
approved these changes
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #381
styleInjectRelativePath
Type:
booleanDefault: true
The built file will contain a relative path to the style-inject module:
This is fine if your project is the final consumer of this library.
If you are creating an ESM library to be used by other projects, then you will want to specify a module path