Skip to content

Support aspectwithbg style#137

Open
horiuchi wants to merge 2 commits intoelad:masterfrom
horiuchi:support-aspectwithbg
Open

Support aspectwithbg style#137
horiuchi wants to merge 2 commits intoelad:masterfrom
horiuchi:support-aspectwithbg

Conversation

@horiuchi
Copy link
Copy Markdown
Contributor

@horiuchi horiuchi commented Aug 9, 2016

No description provided.

@dustingraves
Copy link
Copy Markdown
Contributor

👍
Works on my machine.

@dustingraves
Copy link
Copy Markdown
Contributor

I did notice that it does not work with GIFs (tested with http://cdn.osxdaily.com/wp-content/uploads/2013/07/dancing-banana.gif) because the native code defaults the background to black on gif -> jpg conversion. It also has a problem with some transparent PNGs. i.e: this works http://img.rarediseaseday.org.s3.amazonaws.com/download/rdd-logo-transparent.png but not this http://img07.deviantart.net/da05/i/2013/033/9/2/png_rock_and_tree_by_moonglowlilly-d5tkhw3.png

@rchipka
Copy link
Copy Markdown
Collaborator

rchipka commented Sep 1, 2016

Is this fully implemented by #140?

@horiuchi
Copy link
Copy Markdown
Contributor Author

horiuchi commented Sep 2, 2016

@rchipka No, I need new style that scales the image and fill the rest by background color. It's same as aspectfill, but not cropped image size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants