feat(eloot.lic): v2.9.0 add keep transmogs feature

[mrhoribu]

Updated Lich requirement and version, added feature to keep transmogs, and modified related logic in the script.

Summary by CodeRabbit

• New Features

  • Added "Keep Transmogs" setting (disabled by default) to preserve transmog-capable jewelry and clothing items instead of selling or discarding them during looting sessions.

• Improvements

  • Updated script compatibility requirements and enhanced transmog item detection capabilities.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR adds a transmog detection feature to the ELoot script. A new is_transmog? method identifies transmog-capable jewelry and clothing items via ANALYZE analysis. Four sell handlers (custom list, pawnshop, gemshop, and herb dump) now skip selling detected transmogs when the keep_transmogs setting is enabled, instead keeping them in inventory.

Changes

Transmog Detection & Keeping

Layer / File(s)	Summary
Metadata & Defaults scripts/eloot.lic (lines 14–22, 777–779, 1888–1889)	Lich requirement updated to >= 5.15.0, script version bumped to 2.9.0, and keep_transmogs setting (default false) added to Setup UI and defaults hash.
Data Model scripts/eloot.lic (lines 262–265, 346)	transmog_cache attribute added to ELoot::Data and initialized as a session-scoped cache keyed by [item.id, item.name] for transmog detection results.
Transmog Detection scripts/eloot.lic (lines 3348–3370)	New ELoot::Inventory.is_transmog?(item, analyze_lines: nil) method detects jewelry/clothing with transmog capability via ANALYZE, returning cached boolean results.
Sell Handler Integration scripts/eloot.lic (lines 5833–5840, 5976–5977, 6172–6176, 6698–6703)	Sell.custom_list, Sell.gemshop, Sell.dump_herbs_junk, and Sell.pawnshop updated to detect transmogs and skip selling/trashing when keep_transmogs is enabled, storing detected transmogs via Inventory.single_drag.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

• OSXLich-Doug

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately reflects the main change: adding a 'keep transmogs' feature and bumping to version 2.9.0. It is concise, specific, and clearly summarizes the primary change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/eloot-v2.9.0

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@scripts/eloot.lic`:
- Around line 3359-3360: The is_transmog? method currently does item.type =~
/jewelry|clothing/ which will raise if item.type is nil; update is_transmog? to
coerce the type to a safe string (e.g., use item.type.to_s or a
nil-to-empty-string guard) before applying the =~ match and keep the existing
checks for after_name to prevent nil errors during sell/dump flows when
keep_transmogs is enabled.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 83fe8838-46ee-4867-ba20-9644192d9b7a

📥 Commits

Reviewing files that changed from the base of the PR and between 9b8108d and fe27dc5.

📒 Files selected for processing (1)

• scripts/eloot.lic