fix(autostart.lic): load dependency before DR scripts

[MahtraDR]

Summary

• v0.68 moved the YAML autostart loop above the DR dependency block, causing DR scripts (tome, moonwatch, etc.) to start before dependency.lic loads
• These scripts call parse_args(), a bridge function defined in dependency.lic:148 that wraps ArgParser.new.parse_args(...) -- it is not provided by lich-5 core
• Swaps the two blocks to restore the v0.67 ordering: start dependency first, then user scripts

Root cause

v0.67 (correct order):

start_scripts_if_available('dependency')  # 1. dependency loads, defines parse_args()
dr_autostarts.each { start_script(...) }  # 2. scripts can call parse_args()

v0.68 (broken order):

all_autostarts.each { start_script(...) } # 1. scripts call parse_args() -- undefined!
start_scripts_if_available('dependency')  # 2. too late

Errors observed

--- Lich: error: undefined method 'parse_args' for an instance of Lich::Common::Tome
    tome:18:in 'Lich::Common::Tome#initialize'

--- Lich: error: undefined method 'parse_args' for module Lich::Common
    moonwatch:23:in 'Lich::Common#_script'

Test plan

• Login to DR and verify dependency loads before tome/moonwatch
• Verify parse_args() errors no longer appear on startup
• Verify non-DR games still get the game-agnostic autostart loop

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes

  • Improved autostart dependency loading for DragonRealms to ensure dependencies are available early
  • Removed legacy first-run path

• Refactor

  • Reorganized autostart configuration structure and YAML formatting while preserving existing startup behavior

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR updates scripts/autostart.lic to add a DragonRealms-specific prelude that loads the dependency script early in the startup sequence, removes the legacy DR dependency path, and reformats the YAML-based autostart configuration block while preserving its core aggregation logic.

Changes

DragonRealms Dependency Prelude and Autostart Refactor

Layer / File(s)	Summary
DR Prelude Logic scripts/autostart.lic (lines 141–146)	New DR-specific prelude loads dependency before other scripts and attempts to start it via start_scripts_if_available('dependency'), ensuring the parse_args bridge is ready early.
Legacy Path Removal scripts/autostart.lic (lines 176–178)	Legacy DR-first-run dependency installation path is removed and replaced by the new DR prelude, eliminating the redundant fallback flow.
YAML Block Reorganization scripts/autostart.lic (lines 179–202)	Autostart configuration block is reformatted with adjusted spacing and line breaks; aggregation logic from UserVars and get_settings, override application, and script execution flow remain functionally unchanged.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• elanthia-online/scripts#2277: Both PRs coordinate DR autostart handling—this PR adds the early dependency prelude while the related PR switches DR autostart reads to UserVars now that dependency is run-once.
• elanthia-online/scripts#2288: Both PRs add DR-specific autostart paths using start_scripts_if_available('dependency') with fallback to legacy dependency handling.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title directly addresses the main change: restoring correct load ordering so dependency.lic loads before DR scripts that depend on it.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}