Skip to content

fix(eloot.lic): v2.9.1 enhance is_transmog? method#2324

Merged
mrhoribu merged 3 commits into
masterfrom
fix/eloot-v2.9.1
May 13, 2026
Merged

fix(eloot.lic): v2.9.1 enhance is_transmog? method#2324
mrhoribu merged 3 commits into
masterfrom
fix/eloot-v2.9.1

Conversation

@mrhoribu
Copy link
Copy Markdown
Contributor

@mrhoribu mrhoribu commented May 13, 2026

Updated version to 2.9.1 and enhanced transmog checks.

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced transmog detection to properly support armor, weapon, and uncommon item types as transmog candidates, in addition to previously supported jewelry and clothing. This expansion improves transmog item identification accuracy while maintaining all existing validation requirements.

Review Change Stack

Updated version to 2.9.1 and enhanced transmog checks.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

Warning

Rate limit exceeded

@mrhoribu has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 42 minutes and 34 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ca8b2230-5d88-452d-9a5d-2d2d63e12fe7

📥 Commits

Reviewing files that changed from the base of the PR and between f59a4dd and cfa0325.

📒 Files selected for processing (1)
  • scripts/eloot.lic
📝 Walkthrough

Walkthrough

The PR updates the transmog detection logic in scripts/eloot.lic to recognize additional item categories (armor, weapon, uncommon) as transmog candidates, alongside the existing jewelry and clothing checks. Version and inline documentation are updated to reflect this expanded scope.

Changes

Transmog detection expansion

Layer / File(s) Summary
Transmog type expansion and version update
scripts/eloot.lic
Version bumped to v2.9.1 with changelog noting transmog detection improvement. Inventory.is_transmog? inline documentation and logic both expanded from jewelry|clothing to jewelry|clothing|armor|weapon|uncommon while preserving the non-empty after_name requirement.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • elanthia-online/scripts#2311: Earlier PR introduced the keep-transmogs feature with narrower jewelry|clothing type checks; this PR expands those type filters to support additional categories.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes: a version bump to v2.9.1 and an enhancement to the is_transmog? method that broadens transmog detection logic.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/eloot-v2.9.1

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@scripts/eloot.lic`:
- Line 3361: The transmog eligibility check was expanded to include
armor/weapon/uncommon (return false unless item.type =~
/jewelry|clothing|armor|weapon|uncommon/), but the "Keep Transmogs" tooltip text
still only mentions jewelry/clothing; update the tooltip string that contains
"Keep Transmogs" (search for the literal tooltip text mentioning
jewelry/clothing around the UI/tooltip rendering code) so it lists the full set
— e.g. "keeps transmogs for jewelry, clothing, armor, weapons, and uncommon
items" — ensuring the wording matches the regex used for item.type.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 85666936-e143-4e49-96a2-bd9a6a642378

📥 Commits

Reviewing files that changed from the base of the PR and between 7389607 and f59a4dd.

📒 Files selected for processing (1)
  • scripts/eloot.lic

Comment thread scripts/eloot.lic
mrhoribu added 2 commits May 13, 2026 11:36
Removed redundant checks for transmogs before dragging items to sell. Simplified the code by consolidating the logic for handling transmogs.
@mrhoribu mrhoribu merged commit 7efcbff into master May 13, 2026
4 checks passed
@mrhoribu mrhoribu deleted the fix/eloot-v2.9.1 branch May 13, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant