-
Notifications
You must be signed in to change notification settings - Fork 186
[Fleet] Document 'Write to logs streams' setting in ES and remote ES output docs #4253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Vale Linting ResultsNo issues found on modified lines! |
🔍 Preview links for changed docs |
mdbirnstiehl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM! I made one suggestion to emphasize that this setting is only part of the process. Feel free to modify as you see fit.
Co-authored-by: Mike Birnstiehl <[email protected]>
| 5. Adjust any settings as preferred. For example, you can update the `compression_level` setting to `4`. | ||
| When you create an {{agent}} policy using this output, the output will use the balanced preset options except with the higher compression level, as specified. | ||
|
|
||
| **Write to logs streams** {applies_to}`serverless: preview` {applies_to}`stack: preview 9.2` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get why these aren't simply H3 - across the whole page. Would it make the "On this page" section hard to read? If not, I don't see why not. You could always make them H4 - then they wouldn't even appear in "On this page".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned in our private conversation on Slack, I think maybe it’s worth keeping the settings out of the heading structure. Skipping heading levels is not good from SEO perspective, but also because these setting names are very diverse and inconsistent. Some are short and undescriptive - which might be a problem from SEO perspective, too - and changing the heading would not really be an option, because these are the names of the actual fields on the UI. Others are long, e.g. "Make this output the default for agent integrations” which is also not a good fit for a heading.
So overall, I think I’d prefer to keep these as they are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having thought about it better, I agree. Approved!
Co-authored-by: Aleksandra Spilkowska <[email protected]>
Summary
This PR documents the “Write to logs streams” setting in the Elasticsearch output settings and Remote Elasticsearch output docs.
Resolves #3855
Generative AI disclosure