Skip to content

Conversation

@kunisen
Copy link
Contributor

@kunisen kunisen commented Dec 11, 2025

Summary

This is to address https://github.com/elastic/docs-content-internal/issues/592.

I am raising this as the first PR to decide the wording with docs, and ES dev / PM team. Thanks!

Generative AI disclosure

  1. Did you use a generative AI (GenAI) tool to assist in creating this contribution?
  • Yes
  • No

Preview / View

Before PR merge

deploy-manage/deploy/self-managed/vm-max-map-count.md

After PR merge

https://www.elastic.co/docs/deploy-manage/deploy/self-managed/vm-max-map-count

@kunisen kunisen requested review from bytebilly and lkts December 11, 2025 08:21
@kunisen kunisen self-assigned this Dec 11, 2025
@kunisen kunisen requested a review from a team as a code owner December 11, 2025 08:21
@kunisen kunisen added documentation Improvements or additions to documentation supportability ability enable self-service or support of product Team:Admin Issues owned by the Admin Docs Team labels Dec 11, 2025
@github-actions
Copy link

github-actions bot commented Dec 11, 2025

✅ Vale Linting Results

No issues found on modified lines!

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

🔍 Preview links for changed docs

Copy link
Contributor

@yetanothertw yetanothertw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@kunisen
Copy link
Contributor Author

kunisen commented Dec 11, 2025

Thank you @yetanothertw for the review and valuable advice as always! 🙏
I will wait for engineering / PM's input & review before I go merge. Thanks for your patience.


By the way, may I have one question about format please?
https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/4295/deploy-manage/deploy/self-managed/vm-max-map-count

I see the admonition directive doesn't seem to show markdown format but shows "`" as is.

image

My question is, should I use ` to quote, or should I avoid using the it? To be more specific, should I do A) or B) please?

  • A)
Verify `vm.max_map_count` configuration
  • B)
Verify vm.max_map_count configuration


# Increase virtual memory [vm-max-map-count]

{{es}} uses a [`mmapfs`](elasticsearch://reference/elasticsearch/index-settings/store.md#mmapfs) directory by default to store its indices. The default operating system limits on mmap counts is likely to be too low, which may result in out of memory exceptions.
Copy link

@lkts lkts Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We say here "The default operating system limits on mmap counts is likely to be too low" but that is no longer true. I think your addition below supersedes this statement and we can remove it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want to say "could be too low"?

Copy link

@lkts lkts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for driving this change. I have one suggestion, otherwise LGTM.


{{es}} uses a [`mmapfs`](elasticsearch://reference/elasticsearch/index-settings/store.md#mmapfs) directory by default to store its indices. The default operating system limits on mmap counts is likely to be too low, which may result in out of memory exceptions.

:::{admonition} Verify `vm.max_map_count` configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:::{admonition} Verify `vm.max_map_count` configuration
:::{admonition} Verify vm.max_map_count configuration

Thanks for spotting this @kunisen -- I missed it!

I think we should go with option B (as described in your comment).

@shainaraskas
Copy link
Collaborator

is this something that should be checked on upgrade, too? that's what I gathered from a couple of the slack conversations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation supportability ability enable self-service or support of product Team:Admin Issues owned by the Admin Docs Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants