[EuiInMemoryTable] Support controlled plain text search

[acstll]

Summary

Closes #9019 (see #9019 (comment))

This addresses 2 issues with EuiInMemoryTable when used with plain text, namely searchFormat="text", it:

• enables "controlled" support via the search.query prop
• ensure search.defaultQuery is being passed to the search box

It's a follow-up for a previous fix in #9059

Why are we making this change?

To fix a bug, and to unblock fixing another bug in Kibana.

Impact to users

🟢 Since this is a bug fix impact should just be positive, but tests may fail expecting the old broken behavior. However, no instances of searchFormat="text" can be found in Kibana with a simple search. And these changes should not affect the default searchFormat="eql".

QA

Suggestion

The bug happens when the component attempts to parse the search value as EQL syntax despite searchFormat being text, although it shouldn't, as expressed in the description of the searchFormat prop.

To reproduce it, you can:

• copy/paste the test story (23d9e8b) in main
• run Storybook, open the story: http://localhost:6006/?path=/story/tabular-content-euiinmemorytable--controlled-text
• typing or in the search box should throw an error and break
• verify the value for searchText is text and the controlled logic is correct
• to test search.defaultQuery works as expected, in the Storybook UI you can set the search prop to { query: null, defaultQuery: 'hello world' }

This test story should work as expected in this branch.

General checklist

• Browser QA
  • Checked in both light and dark modes
  • Checked in both MacOS and Windows high contrast modes
    • (emulate forced colors if you do not have access to a Windows machine.)
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Checked for accessibility including keyboard-only and screenreader modes
• Docs site QA
  • Added documentation
  • Props have proper autodocs (using @default if default values are missing) and playground toggles
  • Checked Code Sandbox works for any docs examples
• Code quality checklist
  • Added or updated jest and cypress tests
  • Updated visual regression tests
• Release checklist
  • A changelog entry exists and is marked appropriately
  • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • If the changes unblock an issue in a different repo, smoke tested carefully (see Testing EUI features in Kibana ahead of time)
• Designer checklist
  • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

[rmyz]

Tested against local kibana with elastic/kibana#233836 and it works fine, thanks!

[mgadewoll]

✅ The updated search.query and search.defaultQuery props work as expected:

• query no longer results in an error for searchFormat="text"
• defaultQuery is properly applied

I have one doubt about a possible edge case, otherwise the changes LGTM.

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 74d05ec
• Documentation website
• Storybook

History

• 💚 Build #2072 succeeded 6e40d54
• 💚 Build #2052 succeeded 23d9e8b
• 💚 Build #1995 succeeded 9967c96
• 💚 Build #1680 succeeded ebe0bf2

cc @acstll

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 74d05ec

History

• 💚 Build #5319 succeeded 6e40d54
• 💚 Build #5307 succeeded 23d9e8b
• 💚 Build #5259 succeeded 9967c96
• 💚 Build #5024 succeeded ebe0bf2

cc @acstll

[mgadewoll]

🟢 Thanks for the additional changes! The code LGTM and the updated search.query and search.defaultQuery work as expected 👍