Skip to content

Conversation

@tsullivan
Copy link
Member

@tsullivan tsullivan commented May 23, 2025

Summary

Epic: https://github.com/elastic/kibana-team/issues/1606

Flyout.Demo.2.mp4

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@elasticmachine
Copy link
Contributor

elasticmachine commented May 23, 2025

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!

@tsullivan tsullivan force-pushed the mvp/use-managed-flyout branch 4 times, most recently from 9aa0a5c to 0f1f39c Compare May 29, 2025 00:09
@elastic elastic deleted a comment from elasticmachine May 29, 2025
@elastic elastic deleted a comment from elasticmachine May 29, 2025
@tsullivan tsullivan force-pushed the mvp/use-managed-flyout branch 5 times, most recently from 775e90d to 51eb93b Compare June 5, 2025 23:12
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
core 395 399 +4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/core-overlays-browser 28 62 +34

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/core 874 877 +3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 440.0KB 445.2KB +5.3KB
Unknown metric groups

API count

id before after diff
@kbn/core-overlays-browser 53 87 +34

History

@tsullivan tsullivan force-pushed the mvp/use-managed-flyout branch from 2ea2b7e to 49e7d46 Compare June 25, 2025 16:14
@tsullivan
Copy link
Member Author

Replaced with #233806

@tsullivan tsullivan closed this Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants