Skip to content

build: use spawn instead of spawnSync for build#808

Merged
jkleinsc merged 1 commit intomainfrom
depot-spawn
Feb 12, 2026
Merged

build: use spawn instead of spawnSync for build#808
jkleinsc merged 1 commit intomainfrom
depot-spawn

Conversation

@jkleinsc
Copy link
Member

3.91s Error: failed to load build.ninja: open obj\components\optimization_guide\core\features.ninja: The parameter is incorrect.

In theory its possible that spawnSync could cause file contention since it is synchronous, so this PR changes to instead use child_process.spawn to call ninja/autoninja and gn.

@jkleinsc jkleinsc requested review from a team and ckerr as code owners February 12, 2026 20:12
@jkleinsc jkleinsc merged commit a0cc95a into main Feb 12, 2026
10 checks passed
@jkleinsc jkleinsc deleted the depot-spawn branch February 12, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants