Repository navigation
build(deps-dev): bump @electron-forge/maker-squirrel from 8.0.0-alpha.10 to 8.0.1 - #2064
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| "@electron-forge/core-utils@npm:8.0.1": | ||
| version: 8.0.1 | ||
| resolution: "@electron-forge/core-utils@npm:8.0.1" | ||
| dependencies: | ||
| "@electron-forge/shared-types": "npm:8.0.1" | ||
| "@electron/rebuild": "npm:^4.2.0" | ||
| "@malept/cross-spawn-promise": "npm:^2.0.0" | ||
| debug: "npm:^4.3.1" | ||
| graceful-fs: "npm:^4.2.11" | ||
| semver: "npm:^7.2.1" | ||
| checksum: 10c0/b24600949704edebdc753eb595f5bc803d3772e741b01c431252cf8fcb4802e72397bb8e27d975e2ac7f594d75005f18e3de5295f85a4d129c7612de63153cd6 | ||
| languageName: node |
There was a problem hiding this comment.
🔴 CI and release jobs will fail at install, because the lockfile is missing two packages the new maker-squirrel needs. yarn install --immutable would have to add them and stops. The new @ electron-forge/maker-squirrel@ npm:8.0.1 and @ electron-forge/core-utils@ npm:8.0.1 entries depend on @ electron-forge/maker-base and @ electron-forge/shared-types at npm:8.0.1. Only the 8.0.0-alpha.10 entries for those two exist (yarn.lock:421, yarn.lock:558). Fix: regenerate yarn.lock with flock /tmp/fiddle-2027-yarn.lock yarn install so every npm:8.0.1 dependency has an entry. Bumping all @ electron-forge/* packages to 8.0.1 together also avoids mixing alpha and stable Forge versions.
Why this was flagged
The trigger is any CI or release run, which installs with yarn install --immutable (.github/workflows/ci.yml:56, ci.yml:138, release.yml:57, release.yml:127, release.yml:220). yarn.lock:387-398 adds @ electron-forge/core-utils@ npm:8.0.1, which depends on @ electron-forge/shared-types: npm:8.0.1. yarn.lock:471-478 changes maker-squirrel so it depends on @ electron-forge/maker-base: npm:8.0.1 and @ electron-forge/shared-types: npm:8.0.1. The lockfile has no resolution entry for either descriptor. The only ones are @ electron-forge/maker-base@ npm:8.0.0-alpha.10 (yarn.lock:421) and @ electron-forge/shared-types@ npm:8.0.0-alpha.10 (yarn.lock:558). Yarn Berry must add those entries during resolution, and --immutable fails with YN0028 "The lockfile would have been modified by this install, which is explicitly forbidden". On the base branch the lockfile is consistent and the install succeeds. After this change, lint, test and the yarn make release jobs never get past install. Nothing guards against this: the lockfile was edited by hand or only partly regenerated.
Verification: The trigger is any CI or release job running yarn install --immutable (.github/workflows/ci.yml:56). Maker-squirrel (yarn.lock:471-478) depends on maker-base and shared-types at npm:8.0.1, but yarn.lock has only their alpha.10 entries (lines 421 and 558). With --immutable, any change to the lockfile is an error (YN0028), so install aborts in every CI and release job.
Bumps [@electron-forge/maker-squirrel](https://github.com/electron/forge) from 8.0.0-alpha.10 to 8.0.1. - [Release notes](https://github.com/electron/forge/releases) - [Changelog](https://github.com/electron/forge/blob/main/CHANGELOG.md) - [Commits](electron/forge@v8.0.0-alpha.10...v8.0.1) --- updated-dependencies: - dependency-name: "@electron-forge/maker-squirrel" dependency-version: 8.0.1 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
fc42d47 to
0c4328e
Compare
There was a problem hiding this comment.
Code review found no new issues
No new issues were found in this update; 1 finding from earlier reviews is still open above.
Still open from earlier reviews (1):
- 🔴
yarn.lock:398—CI and release jobs will fail at install, because the lockfile is missing two packages the new maker-squirrel needs. ya…
If you have decided not to act on one of these findings, resolve its thread (a reply alone leaves it open) and the next review stops counting it. To review this commit again now, use Re-run on its "Claude Code Review" check.
Bumps @electron-forge/maker-squirrel from 8.0.0-alpha.10 to 8.0.1.
Release notes
Sourced from @electron-forge/maker-squirrel's releases.
... (truncated)
Changelog
Sourced from @electron-forge/maker-squirrel's changelog.
... (truncated)
Commits
48f38bbchore: bump version to 8.0.1 (#4426)40b4adfchore: bump version to 8.0.0 (#4425)2868de8refactor(maker-appx)!: reimplement as a legacy wrapper over the MSIX maker (#...d7c592cdocs: add AGENTS.md guidance for AI coding agents (#4416)5023ae1build(deps): upgrade Electron to 44.4.3 (#4410)1d268aabuild(deps): bump vulnerable transitive and direct dependencies (#4408)c7bae14fix(template): typecheck root-level config files (#4407)198d934fix(template-vite): use .mts for Vite configs in the TypeScript variant (#4406)e0fb4d4build: bump@electron/lint-rollerto ^4.0.0 (#4404)7b2f0e8feat!: replacerelease --from-dry-runwith--from-make, and `make --skip-...