-
Notifications
You must be signed in to change notification settings - Fork 136
Support MSC4143 RTC Transport endpoint #3629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: livekit
Are you sure you want to change the base?
Conversation
…nsports before response.
|
This needs more coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks sensible.
If one of them fails we always run into a hard error. Do we want automatically check if we suceed in loading one of the lower prio ones?
Yup! Working through it |
|
In other words: I am not sure if:
is actually happening. Are we really continuing to check well-known transports if backend transports fail? |
That was my intention yes, but seeing as it wasn't clear this needs more comments on the PR. |
This implements MSC4143's backend endpoint for transports, and uses matrix-org/matrix-js-sdk#5104 to handle it.
This changes makeTransport to: