-
Notifications
You must be signed in to change notification settings - Fork 138
fix: add explicit sqlserver__ dispatch to T-SQL fabric macros (CORE-877) #1013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
77c03be
007b5e0
850ce99
94c42cc
a14dd71
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -24,6 +24,10 @@ | |||||||||||||
| {% do return("merge") %} | ||||||||||||||
| {% endmacro %} | ||||||||||||||
|
|
||||||||||||||
| {%- macro sqlserver__get_default_incremental_strategy() %} | ||||||||||||||
| {% do return(elementary.fabric__get_default_incremental_strategy()) %} | ||||||||||||||
| {% endmacro %} | ||||||||||||||
|
Comment on lines
+27
to
+29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Keep SQL Server on adapter-default incremental strategy. Line 28 delegates SQL Server to Suggested fix {%- macro sqlserver__get_default_incremental_strategy() %}
- {% do return(elementary.fabric__get_default_incremental_strategy()) %}
+ {% do return(none) %}
{% endmacro %}Based on learnings: In 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||
|
|
||||||||||||||
| {%- macro fabricspark__get_default_incremental_strategy() %} | ||||||||||||||
| {{ return(elementary.spark__get_default_incremental_strategy()) }} | ||||||||||||||
| {% endmacro %} | ||||||||||||||
|
|
||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.