CORE-877: Fix microbatch integration test for Fabric#1015
Conversation
Use DbtProject.is_tsql to select datetime2 on T-SQL targets instead of checking sqlserver only. Co-authored-by: Cursor <cursoragent@cursor.com>
|
👋 @elazarlachkar |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe microbatch source-model SQL generator was changed to remove the adapter-specific Jinja computation of event_time_data_type and to cast ChangesMicrobatch SQL change
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Lets adapter dispatch pick the correct timestamp type for Fabric and other targets. Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
DbtProject.is_tsqlwhen generating microbatch source model SQL in integration testsdatetime2forevent_timecasts (same as SQL Server) instead of invalidtimestampTest plan
Made with Cursor
Summary by CodeRabbit