Skip to content

chore: update dbt-data-reliability to include elementary_extra_indexes support#2265

Merged
haritamar merged 2 commits into
masterfrom
devin/1780472166-update-dbt-data-reliability-ref
Jun 3, 2026
Merged

chore: update dbt-data-reliability to include elementary_extra_indexes support#2265
haritamar merged 2 commits into
masterfrom
devin/1780472166-update-dbt-data-reliability-ref

Conversation

@haritamar
Copy link
Copy Markdown
Collaborator

@haritamar haritamar commented Jun 3, 2026

Summary

Updates packages.yml to point to the merged commit on dbt-data-reliability master (3dc104a1) which includes the elementary_extra_indexes config var support (PR #1019).

This is a dependency-chain update — the elementary-internal cloud runner passes elementary_extra_indexes via dbt vars to inject custom indexes (e.g., (created_at, resource_type) on dbt_run_results) into synced schema tables. This PR picks up that macro support so elementary-internal can reference it.

Merge order: dbt-data-reliability #1019 (merged) → this PR → elementary-internal #6500

Link to Devin session: https://app.devin.ai/sessions/278ceddbe6d24dbea36a83ecc232f3b6
Requested by: @haritamar

Summary by CodeRabbit

  • Chores
    • Switched the dbt dependency to the data-reliability package using a git-based source for dependency management.
    • Updated project lock/configuration to reflect the new git-sourced dependency and refreshed integrity information to ensure reproducible installs.

@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

👋 @haritamar
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Replace the published elementary-data/elementary package pin with a git-based elementary-data/dbt-data-reliability dependency pinned to commit 3dc104a13cda8dd4a0fbcec41a97706acb110643, and update the package lock sha1_hash and package entry accordingly.

Changes

Package Source Migration

Layer / File(s) Summary
dbt-data-reliability git source configuration
elementary/monitor/dbt_project/packages.yml, elementary/monitor/dbt_project/package-lock.yml
Replaces the elementary-data/elementary version pin (0.24.0) with a git source referencing https://github.com/elementary-data/dbt-data-reliability.git at revision 3dc104a13cda8dd4a0fbcec41a97706acb110643, and updates the lockfile sha1_hash and package entry accordingly.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • GuyEshdat
  • NoyaArie

Poem

🐇 I hopped from tag to git with glee,
A commit hash snug as can be.
The lockfile twitched, the pins aligned,
Small changes neat, no fuss to find.
Hooray — a rabbit's tidy spree.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating dbt-data-reliability dependency to a specific revision that includes elementary_extra_indexes support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch devin/1780472166-update-dbt-data-reliability-ref

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@elementary/monitor/dbt_project/packages.yml`:
- Line 5: The dbt dependency revision for dbt-data-reliability is out of sync:
packages.yml pins revision 3dc104a13cda8dd4a0fbcec41a97706acb110643 while
package-lock.yml still references d4a280c3f97c33c156875302d6d294c0792c234e;
regenerate the lock so both files match by running dbt deps --lock against the
elementary/monitor/dbt_project (this will update package-lock.yml to the
revision in packages.yml).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cc4b35c1-c0c1-465d-8ba7-87f52d7f9026

📥 Commits

Reviewing files that changed from the base of the PR and between f6cd92f and 1758bd2.

📒 Files selected for processing (1)
  • elementary/monitor/dbt_project/packages.yml

Comment thread elementary/monitor/dbt_project/packages.yml
devin-ai-integration Bot and others added 2 commits June 3, 2026 16:07
…s support

Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
@devin-ai-integration devin-ai-integration Bot force-pushed the devin/1780472166-update-dbt-data-reliability-ref branch from fb3c5a7 to dff303a Compare June 3, 2026 16:09
@haritamar haritamar merged commit 9cc84dd into master Jun 3, 2026
25 checks passed
@haritamar haritamar deleted the devin/1780472166-update-dbt-data-reliability-ref branch June 3, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants