chore: Update dbt package#2266
Conversation
|
👋 @elazarlachkar |
📝 WalkthroughWalkthroughThe monitoring dbt project's package dependencies are updated to reference the Changesdbt-data-reliability Dependency Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@elementary/monitor/dbt_project/packages.yml`:
- Around line 4-5: The required-package detection in
_get_required_packages_names only looks for entries with a "package" key and
thus misses git-only entries like the dbt-data-reliability entry; update
_get_required_packages_names to also consider entries that have a "git" (or
"git+" ) key and treat them as required by deriving a deterministic package
identifier (e.g., repository name from the git URL) or by returning a marker for
git-sourced packages so _run_deps_if_needed will not skip deps(); reference
_get_required_packages_names and _run_deps_if_needed when making the change so
the deps-skipping logic correctly detects git-only package entries.
- Around line 4-5: The packages.yml entry currently uses a git ref for
dbt-data-reliability which violates the release validation contract; replace the
git block (git: ... revision: ...) with the approved package format: add
package: elementary-data/elementary and a concrete version: <version> (use the
required release-compatible version) so the file contains the package:
elementary-data/elementary and version: fields instead of the git/revision
fields to satisfy the release.yml validation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 048aed81-4806-4919-b4b0-2ba977d88947
📒 Files selected for processing (2)
elementary/monitor/dbt_project/package-lock.ymlelementary/monitor/dbt_project/packages.yml
| - git: https://github.com/elementary-data/dbt-data-reliability.git | ||
| revision: 1aa94e4dd7c084d01e3341a57f61aa325bf4f8a3 |
There was a problem hiding this comment.
Git dependency is skipped by required-package detection in the dbt runner.
elementary/clients/dbt/command_line_dbt_runner.py (_get_required_packages_names, Lines 447-492 snippet) only collects entries with a package key. This new git-only entry won’t be considered required, so _run_deps_if_needed() can incorrectly skip deps() when dbt-data-reliability is missing.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@elementary/monitor/dbt_project/packages.yml` around lines 4 - 5, The
required-package detection in _get_required_packages_names only looks for
entries with a "package" key and thus misses git-only entries like the
dbt-data-reliability entry; update _get_required_packages_names to also consider
entries that have a "git" (or "git+" ) key and treat them as required by
deriving a deterministic package identifier (e.g., repository name from the git
URL) or by returning a marker for git-sourced packages so _run_deps_if_needed
will not skip deps(); reference _get_required_packages_names and
_run_deps_if_needed when making the change so the deps-skipping logic correctly
detects git-only package entries.
This format conflicts with the current release validation contract.
.github/workflows/release.yml (Lines 60-90 snippet) explicitly fails if packages.yml contains a git ref for dbt-data-reliability and requires package: elementary-data/elementary with version:. Merging this as-is makes the next release flow fail unless another change updates that contract.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@elementary/monitor/dbt_project/packages.yml` around lines 4 - 5, The
packages.yml entry currently uses a git ref for dbt-data-reliability which
violates the release validation contract; replace the git block (git: ...
revision: ...) with the approved package format: add package:
elementary-data/elementary and a concrete version: <version> (use the required
release-compatible version) so the file contains the package:
elementary-data/elementary and version: fields instead of the git/revision
fields to satisfy the release.yml validation.
Summary by CodeRabbit