Skip to content

chore: Update dbt package#2266

Merged
elazarlachkar merged 1 commit into
masterfrom
core-930-update-elementary-package
Jun 3, 2026
Merged

chore: Update dbt package#2266
elazarlachkar merged 1 commit into
masterfrom
core-930-update-elementary-package

Conversation

@elazarlachkar
Copy link
Copy Markdown
Contributor

@elazarlachkar elazarlachkar commented Jun 3, 2026

Summary by CodeRabbit

  • Chores
    • Updated package dependencies for enhanced data reliability monitoring capabilities.

@elazarlachkar elazarlachkar requested a review from NoyaArie June 3, 2026 13:56
@elazarlachkar elazarlachkar self-assigned this Jun 3, 2026
@linear
Copy link
Copy Markdown

linear Bot commented Jun 3, 2026

CORE-930

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

👋 @elazarlachkar
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

The monitoring dbt project's package dependencies are updated to reference the dbt-data-reliability repository via Git rather than a versioned package. Both the manifest and lock files are synchronized with the same source and commit revision.

Changes

dbt-data-reliability Dependency Update

Layer / File(s) Summary
Update to git-based dbt-data-reliability dependency
elementary/monitor/dbt_project/packages.yml, elementary/monitor/dbt_project/package-lock.yml
The dependency definition switches from a version-pinned elementary-data/elementary package to a Git-based source on elementary-data/dbt-data-reliability, pinning the manifest to a specific commit revision. The lock file is regenerated with the matching git revision and computed sha1_hash.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • NoyaArie
  • GuyEshdat

Poem

A rabbit hops through package trees,
Git revision on the breeze,
dbt-data-reliability in sight,
Lock files sync'd with hash so bright! 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'chore: Update dbt package' is vague and generic, using non-descriptive terms that don't convey the specific nature of the change. Consider using a more specific title that identifies which package is being updated and what the change entails (e.g., 'chore: Switch to dbt-data-reliability package' or 'chore: Update elementary package dependency').
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch core-930-update-elementary-package

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@elementary/monitor/dbt_project/packages.yml`:
- Around line 4-5: The required-package detection in
_get_required_packages_names only looks for entries with a "package" key and
thus misses git-only entries like the dbt-data-reliability entry; update
_get_required_packages_names to also consider entries that have a "git" (or
"git+" ) key and treat them as required by deriving a deterministic package
identifier (e.g., repository name from the git URL) or by returning a marker for
git-sourced packages so _run_deps_if_needed will not skip deps(); reference
_get_required_packages_names and _run_deps_if_needed when making the change so
the deps-skipping logic correctly detects git-only package entries.
- Around line 4-5: The packages.yml entry currently uses a git ref for
dbt-data-reliability which violates the release validation contract; replace the
git block (git: ... revision: ...) with the approved package format: add
package: elementary-data/elementary and a concrete version: <version> (use the
required release-compatible version) so the file contains the package:
elementary-data/elementary and version: fields instead of the git/revision
fields to satisfy the release.yml validation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 048aed81-4806-4919-b4b0-2ba977d88947

📥 Commits

Reviewing files that changed from the base of the PR and between 2983d6f and 5722c45.

📒 Files selected for processing (2)
  • elementary/monitor/dbt_project/package-lock.yml
  • elementary/monitor/dbt_project/packages.yml

Comment on lines +4 to +5
- git: https://github.com/elementary-data/dbt-data-reliability.git
revision: 1aa94e4dd7c084d01e3341a57f61aa325bf4f8a3
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift

Git dependency is skipped by required-package detection in the dbt runner.

elementary/clients/dbt/command_line_dbt_runner.py (_get_required_packages_names, Lines 447-492 snippet) only collects entries with a package key. This new git-only entry won’t be considered required, so _run_deps_if_needed() can incorrectly skip deps() when dbt-data-reliability is missing.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@elementary/monitor/dbt_project/packages.yml` around lines 4 - 5, The
required-package detection in _get_required_packages_names only looks for
entries with a "package" key and thus misses git-only entries like the
dbt-data-reliability entry; update _get_required_packages_names to also consider
entries that have a "git" (or "git+" ) key and treat them as required by
deriving a deterministic package identifier (e.g., repository name from the git
URL) or by returning a marker for git-sourced packages so _run_deps_if_needed
will not skip deps(); reference _get_required_packages_names and
_run_deps_if_needed when making the change so the deps-skipping logic correctly
detects git-only package entries.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

This format conflicts with the current release validation contract.

.github/workflows/release.yml (Lines 60-90 snippet) explicitly fails if packages.yml contains a git ref for dbt-data-reliability and requires package: elementary-data/elementary with version:. Merging this as-is makes the next release flow fail unless another change updates that contract.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@elementary/monitor/dbt_project/packages.yml` around lines 4 - 5, The
packages.yml entry currently uses a git ref for dbt-data-reliability which
violates the release validation contract; replace the git block (git: ...
revision: ...) with the approved package format: add package:
elementary-data/elementary and a concrete version: <version> (use the required
release-compatible version) so the file contains the package:
elementary-data/elementary and version: fields instead of the git/revision
fields to satisfy the release.yml validation.

@elazarlachkar elazarlachkar merged commit dc0e0d6 into master Jun 3, 2026
26 of 27 checks passed
@elazarlachkar elazarlachkar deleted the core-930-update-elementary-package branch June 3, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants