Skip to content

Fix: Do not destroy the MainWindow on close when the indicator is enabled #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stsdc merged 3 commits into from
Mar 26, 2026
Merged

Fix: Do not destroy the MainWindow on close when the indicator is enabled #530

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4638a85
MainWindow: do not destroy the MainWindow on close when the indicator…
stsdc Mar 11, 2026
a94d5cb
MainWindow: Use GDK consts to handle close request
stsdc Mar 26, 2026
7ddde82
Merge branch 'main' into stsdc/fix-window-close
stsdc Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/MainWindow.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,17 @@ public class Monitor.MainWindow : Gtk.ApplicationWindow {
construct {
title = _("Monitor");

close_request.connect (() => {
Copy link
Copy Markdown
Member

@vjr vjr Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the couple of comments I could think about, this PR seems good to merge to me.

It at least fixes for me the need to twice click "show monitor" in panel indicator, now it works everytime first click.

I could not repro perf issue but it could be because I am on a fast desktop PC - I didn't see any issue with window updates (CPU graphs always being smooth) etc.

if (MonitorApp.settings.get_boolean ("indicator-state")) {
debug ("Indicator is enabled, hiding the window instead of closing");
hide ();
return Gdk.EVENT_STOP;
}
debug ("Close the window");
return Gdk.EVENT_PROPAGATE;
});


var resources = new Resources ();

process_view = new ProcessView ();
Expand Down
Loading