[zrm] enable scribe zrm in packages#680
Open
AngeloGiacco wants to merge 1 commit into
Open
Conversation
Member
|
Still think we should consider using affirmative language ( |
kraenhansen
reviewed
Apr 23, 2026
Comment on lines
+109
to
+110
| connection.close(); | ||
| server.close(); |
Member
There was a problem hiding this comment.
This just extends an existing pattern, but closing of test servers should really be a part of an after each hook to prevent cross-talking between tests (in case the test throws midway).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
description
threads through the enable logging param, see #545
testing
added test
Note
Medium Risk
Adds a new
enable_loggingquery parameter that changes server-side logging behavior for Scribe sessions; risk is limited but could affect observability and request compatibility if the backend expects different defaults.Overview
Adds an
enableLoggingoption to Scribe realtime connections and propagates it through the ReactuseScribehook so callers can explicitly enable/disable session logging.Updates WebSocket URI construction to include
enable_logging=true|falseonly when specified, and adds unit tests to cover true/false/omitted cases.Reviewed by Cursor Bugbot for commit 6f07261. Bugbot is set up for automated code reviews on this repo. Configure here.