Upgrade LiveKit dependencies#780
Draft
kraenhansen wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Kræn Hansen <mail@kraenhansen.dk>
Member
Author
6 tasks
Member
Author
|
It's my current understanding that we're blocked on upgrading the LiveKit SDKs as they introduced changes which aren't backwards compatible with the server, we're currently working on upgrading the server to unblock this upgrade. |
Contributor
|
we might not need the git patch after the bump. (see #532) |
|
Is this still in progress? |
Member
Author
|
@kalvin807 can you help me verify that the patch is no longer needed? I agree this seems to be the case (with webrtcHacks/adapter#1177 (comment)) but then this issue popped up 🤔 webrtcHacks/adapter#1194 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
livekit-clientto^2.19.1@livekit/react-nativeto^2.11.0@livekit/react-native-expo-pluginto^1.0.2@livekit/react-native-webrtcto^144.1.0maininto the branch and revert the temporary compatibility changes from Fix WebRTC connection by pinning livekit-client to 2.16.1 #782 now that the service is on LiveKit server 1.12.0:livekit-client@2.16.1pinsinglePeerConnection: falsefromRoomconstructionlivekit-clientpatch registration/filepnpm-lock.yamlwithout LiveKit patch metadata.Validation
pnpm install --frozen-lockfilepnpm build(Node 24 / lts/Krypton)pnpm lint(Node 24 / lts/Krypton)pnpm --filter @elevenlabs/react-native check-typesgit diff --cached --checkNotes
Slack Thread