Move rolldown IIFE config to config files#783
Open
kraenhansen wants to merge 1 commit into
Open
Conversation
Extract inline rolldown CLI options into rolldown.config.ts for both client and react packages. This adds explicit global variable mappings for external dependencies (fixing MISSING_GLOBAL_NAME warnings in the react package) and renames the script from "build:iife" to "bundle". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rolldown.config.tsfor bothclientandreactpackagesoutput.globalsmappings, fixingMISSING_GLOBAL_NAMEwarnings in the react packagebuild:iifescript tobundleTest plan
node --run bundlein both packages produces clean output with no warningspnpm turbo buildpasses across the monorepo🤖 Generated with Claude Code
Note
Low Risk
Low risk build-system change limited to bundling configuration; main risk is accidental differences in IIFE output/globals that could affect CDN consumers.
Overview
Moves IIFE bundling for
@elevenlabs/clientand@elevenlabs/reactfrom inlinerolldownCLI flags to newrolldown.config.tsfiles, and renames the script frombuild:iifetobundle.Adds explicit
output.globalsmappings (including@elevenlabs/clientand@elevenlabs/client/internalfor the React bundle) while keeping the same externals and output targets (dist/lib.iife.jswith sourcemaps).Reviewed by Cursor Bugbot for commit 5b8745e. Bugbot is set up for automated code reviews on this repo. Configure here.