Repository navigation
test(desktop): refresh workflow autocomplete smoke snapshot for Time machine sidebar item - #6
Merged
elijamesku merged 1 commit intoSep 17, 2026
Conversation
…ar item The Time machine entry in the sidebar primary menu changes the full-body render captured by workflow-local-controls "inserts template variables". Snapshot taken from CI's own Linux render (byte-identical across all three retries) so the smoke shard compares against the current sidebar. Signed-off-by: Eli <elijamesau@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Desktop Smoke E2E shard 4 fails on the fork since PR #3:
workflow-local-controls.spec.ts › inserts template variables with keyboard control and restores the caretcompares a full-body screenshot, and the new Time machine sidebar menu item changes that render. The diff image from CI shows a single small delta at the left edge, mid-sidebar — exactly the new menu item.Change
Replace
workflow-template-variable-autocomplete-smoke-linux.pngwith CI's actual render from the PR #4 run. The three retry renders were byte-identical (deterministic), same 1280×720, and the repo's previous snapshot matched CI's "expected" byte-for-byte — so this is a clean swap, not a hand edit.Not touched: the
-darwin.pngsibling (used only for local macOS runs; regenerating it needs Playwright browsers installed locally).Other smoke failures on that run — triage
channels.spec.ts › members sidebar retains distinct same-persona managed agents(Pinky ×4 vs 2): pre-existing on the fork (also failed on PR Sync fork with upstream block/buzz (610 commits) #2's run) — the fork's "Your team" roster renders each managed agent's name in the sidebar, doubling the count. Separate fix.community-rail.spec.ts › hides the rail with a single community(gutter 49.95 vs 9): the helper takes one-shot bounding-box reads immediately after toggling collapse with no animation wait — timing-flaky; nothing in the changed code touches that layout. Passed on PR Sync fork with upstream block/buzz (610 commits) #2's run.workflows.spec.ts×2 (timeouts waiting for the "may run often" confirmation): unrelated to changed code; passed on PR Sync fork with upstream block/buzz (610 commits) #2's run. PR fix(desktop): clippy unnecessary_sort_by in trust ledger #5's run re-executes the same code and will confirm.Test plan
workflow-local-controlssnapshot test passes