Support creating Rust collator resource references usable from Elixir#13
Closed
foxbenjaminfox wants to merge 1 commit into
Closed
Support creating Rust collator resource references usable from Elixir#13foxbenjaminfox wants to merge 1 commit into
foxbenjaminfox wants to merge 1 commit into
Conversation
Collaborator
|
Thanks very much for your efforts, I really appreciate it. In the end I went a different path using the C++ libicu bindings and building out a full Elixir collator as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #9, we want to also have an interface in which the user of the Elixir obtains a reference to a
CollatorRust resource and uses it in multiple calls. This PR implements the NIF API for that interface.This NIF API has a
create_collator/2function that takes a locale and an options map and returns a reference that can be passed as the first argument tosort_using_collator/2. For example: