Clamp panel rects to visible bounds#8056
Open
enomado wants to merge 3 commits into
Open
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/8056-fix-panel-overflow-rect View snapshot changes at kitdiff |
Owner
|
Could you maybe make a regression test for this in |
enomado
added a commit
to enomado/egui
that referenced
this pull request
Apr 7, 2026
Test that SidePanel and TopBottomPanel response.rect and response.interact_rect are clamped to visible panel bounds when content overflows. See: emilk#8056 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
enomado
force-pushed
the
fix-panel-overflow-rect
branch
from
054cb04 to
3bc91e9
Compare
enomado
added a commit
to enomado/egui
that referenced
this pull request
Apr 7, 2026
Panel `response.rect` and `response.interact_rect` were not clamped to visible panel bounds when content inside overflowed, causing callers to receive an oversized rect that broke pointer hit-testing, separator placement, and available_rect advancement (pushing CentralPanel off-screen). Fix: intersect both rects with `panel_rect` in `show_inside_dyn`, and intersect `response.rect` with `available_rect` in `show_dyn`. Regression test + visual snapshot included. See: emilk#8056 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
enomado
force-pushed
the
fix-panel-overflow-rect
branch
from
94c4623 to
fa39354
Compare
Panel `response.rect` and `response.interact_rect` must be clamped to visible panel bounds even when content inside overflows. Before the fix callers received an oversized rect that broke pointer hit-testing, separator placement, and available_rect advancement. See: emilk#8056 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Intersect `response.rect` and `response.interact_rect` with `panel_rect` in `show_inside_dyn`, so callers receive correctly-sized rects that match the visible panel edge. Without this, overflowing content caused the returned rect to exceed the panel bounds, breaking pointer hit-testing and pushing CentralPanel off-screen. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
enomado
force-pushed
the
fix-panel-overflow-rect
branch
from
fa39354 to
ffdf956
Compare
Contributor
Author
|
Sorry for this mess with history. perhaps test is added. I checked up screenshots - sort of reproducing the ptoblem |
Contributor
Author
|
Related issues that may benefit from or overlap with this fix:
|
Contributor
|
This is necessary to prevent a regression introduced in v0.34, where the left panel in my application starts growing automatically: Peek.2026-04-09.02-18.mp4 |
emilk
approved these changes
Apr 9, 2026
Owner
|
This produced some regressions in some existing screenshot tests. I think we may need to dig a bit deeper here. Did anyone do a git bisect to see when this was introduced? Or is this because of a difference in behavior between |
valadaptive
reviewed
Apr 9, 2026
|
|
||
| let inner_response = self.show_inside_dyn(&mut panel_ui, add_contents); | ||
| let rect = inner_response.response.rect; | ||
| let rect = inner_response.response.rect.intersect(available_rect); |
Contributor
There was a problem hiding this comment.
Is this part necessary? inner_response.response.rect is already clamped by show_inside_dyn, which we call directly above this line.
valadaptive
added a commit
to valadaptive/egui
that referenced
this pull request
Apr 9, 2026
A subset of emilk#8056.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8055.
When panel contents overflow beyond the visible clamped bounds, the panel response can become larger than the actual visible panel. That oversized response was then reused by integrations for pointer hit-testing, and its rect was also reused internally for cursor advancement, stored panel state, separator painting, and top-level panel allocation.
This change clamps the outward-facing panel response back to the visible panel bounds with
intersect(panel_rect), for bothresponse.rectandresponse.interact_rect. The fix is applied to bothSidePanelandTopBottomPanel, so callers using the returned panel response do not inherit oversized clipped-child bounds.I verified this against a Bevy + bevy_egui integration where a resizable panel with clipped overflow content incorrectly blocked scene interaction and displaced its effective boundary. After this change, the panel hit area and boundary stay aligned with the visible panel edge.