zero dims gives zero length for img to write - #11
Open
buthanoid wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Looking again at the code of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following code fails:
The problem is that in Julia, the length of a zero dimensional array is one. In the
write()function, we wantlento be the number of scalar value to write, so it should be zero when the array is zero dimensional.In Julia, a zero dimensional array contains a value, whereas in FITS standard it means no data at all.
I suggest to favorise FITS meaning, that is a zero dimensional array has no data, and to disregard the value contained in the Julia zero dimensional array. This suggestion relies on the fact that this is for now, the only way of writing a zero dimensional fits file in EasyFITS (apart from it being bugged)