Skip to content

Conversation

@brunotho
Copy link
Collaborator

@brunotho brunotho commented Sep 19, 2025

This PR diverges from the original issue phrasing.
Instead of adding the edit-button to /happy_things/:date - the titles on that page are now links that lead to the happy things show - which now has the edit-button.

The _happy_thing partial which gets used in several places lost its direct link to the edit page. (editing is not a primary action, removing the triple-dot-button gives more space to the HT title)

Layout change of _happy_thing partial:

Screenshot 2025-09-19 at 10 50 44

Edit on HT show:

Screenshot 2025-09-19 at 11 07 06

/happy_things/:date matching dashboard style:

Screenshot 2025-09-24 at 11 13 34

#155

@brunotho brunotho self-assigned this Sep 19, 2025
@emmvs
Copy link
Owner

emmvs commented Sep 23, 2025

Looks great and works! Only thing is that now on the /date view (http://localhost:3000/happy_things/2025-09-23) one still has the happy things changing colors because they are links now 🔗
Let's update so they look like on the dashboard!
Screenshot 2025-09-23 at 12 12 37

@brunotho
Copy link
Collaborator Author

brunotho commented Sep 23, 2025

Looks great and works! Only thing is that now on the /date view (http://localhost:3000/happy_things/2025-09-23) one still has the happy things changing colors because they are links now 🔗 Let's update so they look like on the dashboard! Screenshot 2025-09-23 at 12 12 37

I'd fully copy the dashboard style here - so get rid of numbers and comments , yes? (comments get moved into show)

nvm, I'll just do it.

@emmvs
Copy link
Owner

emmvs commented Oct 7, 2025

Let's add handling card not breaking bc of too much text in this PR 🙌🏻 And also lets add a max width for desktop view so things look less like shit 💩🫶🏻

@brunotho
Copy link
Collaborator Author

brunotho commented Oct 8, 2025

Two tests are failing now - due to flawed layout / button positioning. I'd merge this anyway together with PR #131 and fix these issues afterwards since there the interface is being changed more drastically than in this PR.

@brunotho brunotho force-pushed the feature/editing-past-happythings branch from 501b2c7 to 8e7d043 Compare October 25, 2025 10:03
@emmvs emmvs changed the title Feature/editing past happythings 🟠 Feature/editing past happythings Oct 25, 2025
@emmvs
Copy link
Owner

emmvs commented Oct 27, 2025

Hmmm, I don't like merging failed tests, maybe comment them out? (and add a TODO 😱)

@brunotho
Copy link
Collaborator Author

Hmmm, I don't like merging failed tests, maybe comment them out? (and add a TODO 😱)

I'd just wait a bit. Finish merging the interface related changes - then merge with this branch again and make it match the new interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants