-
Notifications
You must be signed in to change notification settings - Fork 3
🟠 Feature/editing past happythings #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Let's add handling card not breaking bc of too much text in this PR 🙌🏻 And also lets add a max width for desktop view so things look less like shit 💩🫶🏻 |
|
Two tests are failing now - due to flawed layout / button positioning. I'd merge this anyway together with PR #131 and fix these issues afterwards since there the interface is being changed more drastically than in this PR. |
…g owned by current user
…w, grant more space to ht title
…n HappyThing#show
501b2c7 to
8e7d043
Compare
|
Hmmm, I don't like merging failed tests, maybe comment them out? (and add a TODO 😱) |
I'd just wait a bit. Finish merging the interface related changes - then merge with this branch again and make it match the new interface. |


This PR diverges from the original issue phrasing.
Instead of adding the edit-button to /happy_things/:date - the titles on that page are now links that lead to the happy things show - which now has the edit-button.
The _happy_thing partial which gets used in several places lost its direct link to the edit page. (editing is not a primary action, removing the triple-dot-button gives more space to the HT title)
Layout change of _happy_thing partial:
Edit on HT show:
/happy_things/:date matching dashboard style:
#155