Add support for running output directly in Audio Worklet #25942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
audio_worklet
branch
4 times, most recently
from
39ec937 to
c983f22
Compare
kripken
reviewed
Dec 13, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Dec 13, 2025
- Skip caching of JS output in the presence of user JS libraries. - Include our core js files, since changing them should invalid the cache. Followup to emscripten-core#25942
sbc100
added a commit
that referenced
this pull request
Dec 15, 2025
- Skip caching of JS output in the presence of user JS libraries. - Include our core js files, since changing them should invalid the cache. Followup to #25942
sbc100
force-pushed
the
audio_worklet
branch
2 times, most recently
from
1b5c31f to
bc31c4f
Compare
sbc100
force-pushed
the
audio_worklet
branch
4 times, most recently
from
675d266 to
c4c6ef7
Compare
lindell
approved these changes
Dec 17, 2025
lindell
left a comment
lindell
left a comment
There was a problem hiding this comment.
From my limited experience, it LGTM.
One thing that we might want to add to the docs in some way is to make it clearer in some way that AUDIO_WORKLET and ENVIRONMENT=worklet is two different things?
sbc100
force-pushed
the
audio_worklet
branch
2 times, most recently
from
a39ca89 to
0fbc359
Compare
Collaborator
Author
|
I added some docs. |
kripken
reviewed
Dec 17, 2025
There are some use cases where its useful to be able to run emscripten generated code in an audio worklet without building with `-sAUDIO_WORKLET`. One major one is for deploying in a context where shared memory not available (i.e. no cross origin isolation) Fixes: emscripten-core#25943, emscripten-core#25943
sbc100
force-pushed
the
audio_worklet
branch
from
0fbc359 to
b8a7ed3
Compare
Collaborator
Author
|
@juj, thoughts on this before we land? |
kripken
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some use cases where its useful to be able to run emscripten generated code in an audio worklet without building with
-sAUDIO_WORKLET. One major one is for deploying in a context where shared memory not available (i.e. no cross origin isolation)Fixes: #22979, #25943