[cmake] Fix path to "emscan-deps" on windows

[ProjectHSI]

COMMENT: on my download of emscripten there is no bash script for "scan deps"... is this intentional?

[ProjectHSI]

test-mac-arm64 is a false negative - test was skipped according to circleci.

[sbc100]

lgtm

[sbc100]

IIUC this bug should only effect windows since EMCC_SUFFIX is empty otherwise.

I'm not sure what you mean by "no bash script".. emscan-deps should have .bat file in the windows version as well as the no-extension bash script, just a like all other entry points.

[ProjectHSI]

I'm not sure what you mean by "no bash script".. emscan-deps should have .bat file in the windows version as well as the no-extension bash script, just a like all other entry points.

That is how it appears on my system.

[sbc100]

If your system is windows then its currently expected that we ship only the .bat files and not the shell launcher scripts.

It seems they maybe some reason to ship both though. i.e. msys support?

[ProjectHSI]

If your system is windows then its currently expected that we ship only the .bat files and not the shell launcher scripts.

Yes, my system is Windows and this appears to be the case (although emcc (no extension) is also shipped).
Bash scripts do however (appear to) execute in my install of WSL (I think) when ran via PowerShell/CMD, which causes a separate command prompt to open.

I don't think MSys2 support would be a reason... The tools are already cross-compilers, why run a cross-compiler for a non-Linux platform on MSys2?

[sbc100]

Bash scripts do however (appear to) execute in my install of WSL (I think) when ran via PowerShell/CMD, which causes a separate command prompt to open.

Is this good or bad that this separate command prompt opens? Sounds like maybe not what you want?

I think for WSL users you should probably just install linux version of the SDK. Trying to use the windows SDK from WSL sounds like something we don't currently test/support.

[ProjectHSI]

I think for WSL users you should probably just install linux version of the SDK. Trying to use the windows SDK from WSL sounds like something we don't currently test/support.

Agreed.

Is this good or bad that this separate command prompt opens? Sounds like maybe not what you want?

Erm... Opening a separate command prompt when I already executed it from a command prompt isn't what I want. In fact with Windows Terminal it closes right after finishing the command.

To fix this, just... don't ship with Bash scripts. This only happened with emcc and I just had to specify the .bat file instead. Not too big of an issue (although maybe emcc (bash script) being including is another issue?).

[sbc100]

I think for WSL users you should probably just install linux version of the SDK. Trying to use the windows SDK from WSL sounds like something we don't currently test/support.

Agreed.

Is this good or bad that this separate command prompt opens? Sounds like maybe not what you want?

Erm... Opening a separate command prompt when I already executed it from a command prompt isn't what I want. In fact with Windows Terminal it closes right after finishing the command.

To fix this, just... don't ship with Bash scripts. This only happened with emcc and I just had to specify the .bat file instead. Not too big of an issue (although maybe emcc (bash script) being including is another issue?).

No, we should remove it before shipping.

We include the bash script in the git repository so that folks who do a an initial git checkout and forget to run ./bootstrap can still run ./emcc and see an nice error message telling them do so.

[FakeByte]

I think for WSL users you should probably just install linux version of the SDK. Trying to use the windows SDK from WSL sounds like something we don't currently test/support.

Agreed.

Is this good or bad that this separate command prompt opens? Sounds like maybe not what you want?

Erm... Opening a separate command prompt when I already executed it from a command prompt isn't what I want. In fact with Windows Terminal it closes right after finishing the command.
To fix this, just... don't ship with Bash scripts. This only happened with emcc and I just had to specify the .bat file instead. Not too big of an issue (although maybe emcc (bash script) being including is another issue?).

No, we should remove it before shipping.

We include the bash script in the git repository so that folks who do a an initial git checkout and forget to run ./bootstrap can still run ./emcc and see an nice error message telling them do so.

On windows you can still run bash scripts through the git bash terminal, while I havent done it with emscripten I did that for other projects when using Claude Code which uses git bash as terminal and runs bash scripts and only runs .bat files with the "cmd /c xyz.bat" command. In such cases having the bash files is convenient, while not impossible to workaround though.