[bazel] add support for enabling relaxed SIMD in wasm_cc_binary#1728
Open
DoDoENT wants to merge 2 commits into
Open
[bazel] add support for enabling relaxed SIMD in wasm_cc_binary#1728DoDoENT wants to merge 2 commits into
DoDoENT wants to merge 2 commits into
Conversation
sbc100
approved these changes
Jun 28, 2026
Collaborator
|
This type of breakage seem reasonable to me. Seems easy enough for folks to fixup when the upgrade bazel, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would probably be more elegant to reuse the existing
simdattribute and change it's type from boolean into string enum (similar like it's forthreads), but that would be a breaking change so I decided to add additional boolean acknowlidging thatsimd=False,relaxed_simd=Truemakes no sense and will also enablesimdasrelaxed_simdimpliessimd.If you are comfortable with me breaking the API, I'd be happy to do it (see how I did it in my wrapper)