Skip to content

NXT-17842: [Limestone][InputPopup] Submit button is optional in number type - #408

Merged
ion-andrusciac-lgp merged 4 commits into
developfrom
feature/NXT-17842
Aug 13, 2026
Merged

NXT-17842: [Limestone][InputPopup] Submit button is optional in number type#408
ion-andrusciac-lgp merged 4 commits into
developfrom
feature/NXT-17842

Conversation

@dan-ichim-lgp

@dan-ichim-lgp dan-ichim-lgp commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • I have run automated testing and it is passed
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

noSubmitButton had no visible effect for default/separated number inputs because the Submit button was hidden whenever numberInputField resolved to separated and minLength === maxLength. Sampler links with and without noSubmitButton looked the same.

For type="number" / "passwordnumber", the Submit button can now be shown regardless of numberInputField (auto / joined / separated).

Resolution

Submit is shown by default for number and passwordnumber inputs in all numberInputField modes. Set noSubmitButton to hide it.

For separated fields with minLength === maxLength, auto-submit still runs only when noSubmitButton is true, so the previous no-button flow is preserved while Submit remains available when the button is shown.

Additional Considerations

Links

NXT-17842

Comments

Enact-DCO-1.0-Signed-off-by: Dan Ichim (dan.ichim@lgepartner.com)

@dan-ichim-lgp dan-ichim-lgp self-assigned this Aug 4, 2026
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.68%. Comparing base (3a9bfc4) to head (603e307).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #408      +/-   ##
===========================================
+ Coverage    82.67%   82.68%   +0.01%     
===========================================
  Files          153      153              
  Lines         7623     7623              
  Branches      2319     2319              
===========================================
+ Hits          6302     6303       +1     
+ Misses        1027     1026       -1     
  Partials       294      294              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread Input/tests/Input-specs.js Outdated
Comment thread Input/tests/Input-specs.js
Comment thread Input/Input.js
Comment thread Input/Input.js Outdated
@ion-andrusciac-lgp
ion-andrusciac-lgp merged commit 47ecf18 into develop Aug 13, 2026
6 checks passed
@ion-andrusciac-lgp
ion-andrusciac-lgp deleted the feature/NXT-17842 branch August 13, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants