NXT-17842: [Limestone][InputPopup] Submit button is optional in number type - #408
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #408 +/- ##
===========================================
+ Coverage 82.67% 82.68% +0.01%
===========================================
Files 153 153
Lines 7623 7623
Branches 2319 2319
===========================================
+ Hits 6302 6303 +1
+ Misses 1027 1026 -1
Partials 294 294 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dan-ichim-lgp
force-pushed
the
feature/NXT-17842
branch
from
August 11, 2026 07:17
de6cf3b to
603e307
Compare
ion-andrusciac-lgp
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
noSubmitButton had no visible effect for default/separated number inputs because the Submit button was hidden whenever numberInputField resolved to separated and minLength === maxLength. Sampler links with and without noSubmitButton looked the same.
For type="number" / "passwordnumber", the Submit button can now be shown regardless of numberInputField (auto / joined / separated).
Resolution
Submit is shown by default for number and passwordnumber inputs in all numberInputField modes. Set noSubmitButton to hide it.
For separated fields with minLength === maxLength, auto-submit still runs only when noSubmitButton is true, so the previous no-button flow is preserved while Submit remains available when the button is shown.
Additional Considerations
Links
NXT-17842
Comments
Enact-DCO-1.0-Signed-off-by: Dan Ichim (dan.ichim@lgepartner.com)