Add Monitoring of DHW Temperature (MDT) use case#226
Open
andig wants to merge 2 commits into
Open
Conversation
Adds the ma/mdt use case: a Monitoring Appliance reading a DHW circuit's domestic hot water temperature. Replaces the closed enbility#123 and implements its review feedback: - value state handling: non-normal (out of range / erroneous) readings are ignored and reported as ErrDataInvalid - unit handling: Temperature() takes the requested unit (degC/degF/K) and converts from the unit announced in the measurement description
The degC->degF and degC->K request cases duplicated Test_convertTemperature; the announced-degF->degC case still covers the description-unit conversion path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
ma/mdtuse case: a Monitoring Appliance reading a DHW circuit's domestic hot water temperature, per the EEBus UC TS Monitoring of DHW Temperature v1.0.0 (monitoringOfDhwTemperature, actors DHW Circuit ↔ Monitoring Appliance, scenario 1,Measurementfeature, scopedhwTemperature).Replaces #123 (closed) and implements its review feedback:
outOfRange/error) are ignored and reported asErrDataInvalid, as required by the UC spec ([MDT-005]).Temperature(entity, unit)now takes the requested unit (degC/degF/K) and converts from the unit announced in the measurement description, instead of returning a bare value in an unknown unit.@sthelen-enqs this would be nice with OHPCF.
🤖 Generated with Claude Code