hub: prevent concurrent duplicate outgoing connections to the same SKI#85
Open
andig wants to merge 2 commits into
Open
hub: prevent concurrent duplicate outgoing connections to the same SKI#85andig wants to merge 2 commits into
andig wants to merge 2 commits into
Conversation
andig
commented
Jun 15, 2026
|
coverage: 92.927% (-0.03%) from 92.952% — andig:fix/double-connection-outgoing-dedup into enbility:dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connectFoundServiceonly dedupes outgoing dials viaisSkiConnected, which becomes true afterregisterConnection(i.e. after the websocket dial + SHIP handshake). Two concurrent outgoing dials to the same SKI can both pass that check, both establish, and thenkeepThisConnectiontears one down mid-discovery. Some remotes then stop answering measurement reads on the surviving connection until the whole service is restarted.Reserve the SKI for the duration of the dial via a new
connectionsInitiatingset (guarded bymuxCon), so a concurrent outgoing dial returns early instead of racing to a second handshake. The incoming-vs-outgoing case is still handled bykeepThisConnection.This is a real-live issue observed as a stalled EEBus meter on a Vaillant heatpump in evcc-io/evcc#30889. PR is done by Claude but lgtm.