Skip to content

chore(deps): bump the production-minor-patch group across 1 directory with 2 updates - #175

Open
dependabot[bot] wants to merge 2 commits into
mainfrom
dependabot/npm_and_yarn/production-minor-patch-90d27840f4
Open

chore(deps): bump the production-minor-patch group across 1 directory with 2 updates#175
dependabot[bot] wants to merge 2 commits into
mainfrom
dependabot/npm_and_yarn/production-minor-patch-90d27840f4

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 13, 2026

Copy link
Copy Markdown
Contributor

Bumps the production-minor-patch group with 2 updates in the / directory: monaco-editor and ws.

Updates monaco-editor from 0.52.2 to 0.56.0

Release notes

Sourced from monaco-editor's releases.

v0.56.0

Changes:

  • #5392: Bump websocket-driver from 0.7.4 to 0.7.5 in /website
  • #5396: Release Monaco Editor 0.56.0
  • #5385: Bump websocket-driver from 0.7.4 to 0.7.5 in /samples
  • #5379: Removes leftover debugger statements.
  • #5376: fixes pipeline
  • #5374: Bump webpack-dev-server from 5.2.4 to 5.2.5 in /samples
  • #5373: Bump webpack-dev-server from 5.2.4 to 5.2.5 in /website
  • #5371: Bump undici from 7.24.7 to 7.28.0
  • #5372: Fixes CI
  • #5363: Bump launch-editor from 2.10.0 to 2.14.1 in /samples
  • #5362: Bump @​babel/core from 7.17.8 to 7.29.6 in /samples/browser-esm-webpack-typescript-react
  • #5361: Bump js-yaml from 4.1.1 to 4.2.0
  • #5360: Bump vite from 7.3.2 to 7.3.5
  • #5358: Bump shell-quote from 1.8.3 to 1.8.4 in /samples
  • #5359: Bump ws from 8.20.1 to 8.21.0 in /monaco-lsp-client
  • #5357: Bump esbuild and vite in /samples/browser-esm-vite-react
  • #5354: Bump shell-quote from 1.8.3 to 1.8.4 in /website
  • #5333: Bump dompurify from 3.2.7 to 3.4.5
  • #5347: Revert "Bump dompurify from 3.2.7 to 3.4.5"
  • #5337: Bump qs from 6.14.2 to 6.15.2
  • #5338: Bump qs and express in /samples
  • #5336: Bump qs and express in /website
  • #5335: Bump webpack-dev-server from 5.2.1 to 5.2.4 in /website
  • #5331: Bump ws from 8.18.3 to 8.20.1 in /monaco-lsp-client
  • #5330: Bump webpack-dev-server from 5.2.1 to 5.2.4 in /samples
  • #5326: Run npm audit fix and update lockfile
  • #5323: Bump postcss from 8.5.6 to 8.5.14 in /samples/browser-esm-vite-react
  • #5322: Bump postcss from 8.5.6 to 8.5.14 in /website
  • #5320: Bump @​babel/plugin-transform-modules-systemjs from 7.17.8 to 7.29.4 in /samples/browser-esm-webpack-typescript-react
  • #5317: Bump fast-uri from 3.1.0 to 3.1.2 in /webpack-plugin
  • #5315: Bump fast-uri from 3.0.6 to 3.1.2 in /samples
  • #5316: Bump fast-uri from 3.1.0 to 3.1.2
  • #5318: Bump fast-uri from 3.1.0 to 3.1.2 in /website
  • #5319: Bump fast-uri from 3.1.0 to 3.1.2 in /samples/browser-esm-webpack-typescript-react
  • #5313: Bump postcss from 8.4.31 to 8.5.13 in /samples
  • #5308: Bump postcss from 8.5.6 to 8.5.12
  • #5306: Bump postcss from 8.4.31 to 8.5.10 in /webpack-plugin
  • #5301: Bump follow-redirects from 1.15.9 to 1.16.0 in /samples
  • #5300: Bump follow-redirects from 1.15.11 to 1.16.0 in /website
  • #5299: Bump follow-redirects from 1.15.6 to 1.16.0
  • #5295: Bump vite from 5.4.21 to 6.4.2 in /samples/browser-esm-vite-react
  • #5293: Bump lodash from 4.17.23 to 4.18.1 in /website
  • #5292: Bump lodash from 4.17.23 to 4.18.1 in /samples

... (truncated)

Changelog

Sourced from monaco-editor's changelog.

[0.56.0]

Breaking Changes

  • Reorganizes the exported ESM modules to provide supported, tree-shakeable entry points (#5155). The monaco-editor entry point continues to load all features and languages. Custom bundles can now import monaco-editor/editor and opt into:
    • all editor features with monaco-editor/features/register.all, or individual features with monaco-editor/features/<feature>/register;
    • all language definitions with monaco-editor/languages/definitions/register.all, or individual definitions with monaco-editor/languages/definitions/<language>/register;
    • the CSS, HTML, JSON, and TypeScript language features with monaco-editor/languages/features/register.all, or their individual register entry points.
  • Renames the misspelled IOverlayWidgetPosition.stackOridinal property to stackOrdinal.
  • Removes the deprecated IMirrorModel and IWorkerContext worker API types.

New Features and APIs

  • Adds editor.doubleClickSelectsBlock.
  • Adds editor.find.closeOnResult and editor.inlayHints.showLongLineWarning.
  • Adds offWhenInlineCompletions to QuickSuggestionsValue.
  • Adds model and provider option support to inline completion providers.
  • Adds ICodeEditor.revealAllCursors, ICodeEditor.getWidthOfLine, and ICodeEditor.renderAsync.
  • Adds advanced-external and advanced-wasm diff algorithms.
  • Exposes typed native LSP client and transport APIs.

Fixes

  • Treats Markdown returned by language servers as untrusted (#5280).
  • Updates the editor core to the version used by 0.56.0-dev-20260625.

[0.55.1]

  • Fixes missing language exports (monaco.json/typescript/...) due to wrong "types" path - #5123

[0.55.0]

Breaking Changes

  • Moves nested namespaces (languages.css, languages.html, languages.json, languages.typescript) to top level namespaces (css, html, json, typescript) to simplify the build process and align with typescript recommendations.

New Features

  • Adds native LSP support (see new lsp namespace).

Bug Fixes

  • Updates dompurify to 3.2.7

[0.54.0]

  • Adds option editor.mouseMiddleClickAction
  • Various bug fixes

[0.53.0]

  • ⚠️ This release deprecates the AMD build and ships with significant changes of the AMD build. The AMD build will still be shipped for a while, but we don't offer support for it anymore. Please migrate to the ESM build.

... (truncated)

Commits
  • 13f0c87 Bump websocket-driver from 0.7.4 to 0.7.5 in /website (#5392)
  • b5f23a3 Merge pull request #5396 from microsoft/hediet/b/release-0.56.0
  • 9d053ab Improve Monaco Editor 0.56.0 changelog
  • 0ba33d0 Release Monaco Editor 0.56.0
  • 6d961b1 Bump websocket-driver from 0.7.4 to 0.7.5 in /samples (#5385)
  • d8c9ff0 Removes leftover debugger statements. (#5379)
  • 59285ab fixes pipeline (#5376)
  • aaf58db Bump webpack-dev-server from 5.2.4 to 5.2.5 in /samples (#5374)
  • d8ac38e Bump webpack-dev-server from 5.2.4 to 5.2.5 in /website (#5373)
  • 874af57 Bump undici from 7.24.7 to 7.28.0 (#5371)
  • Additional commits viewable in compare view

Updates ws from 8.21.0 to 8.21.3

Release notes

Sourced from ws's releases.

8.21.3

Bug fixes

  • The server now correctly rejects permessage-deflate offers if the incoming client_max_window_bits parameter value is smaller than its configured clientMaxWindowBits (e97a20ea).

8.21.2

Bug fixes

  • Fixed a test for CITGM (2eb3be0b).

8.21.1

Bug fixes

  • Empty fragments are now counted toward the limit (a2f4e7c0).
  • The default values of the maxBufferedChunks and maxFragments options have been reduced (f197ac65).
Commits
  • c791e70 [dist] 8.21.3
  • e97a20e [fix] Reject offers with client_max_window_bits below config
  • 787ebf2 [dist] 8.21.2
  • b4d62eb Revert "[ci] Trust Coveralls Homebrew tap"
  • e4bb883 [security] Use GitHub PVR as main reporting channel
  • 2eb3be0 [test] Skip test on Node.js versions where it does not apply
  • ae1de54 [dist] 8.21.1
  • 8e9511b [ci] Trust Coveralls Homebrew tap
  • f197ac6 [fix] Lower default values of maxBufferedChunks and maxFragments
  • 8df8265 [ci] Update actions/checkout action to v7
  • Additional commits viewable in compare view

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Aug 13, 2026
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

The following issues were found:
  • ❌ 1 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ✅ 0 package(s) with unknown licenses.
See the Details below.

Vulnerabilities

package-lock.json

NameVersionVulnerabilitySeverity
dompurify3.4.8DOMPurify: Permanent `ALLOWED_ATTR` pollution via `setConfig()` bypassing the hook clone-guard (incomplete fix of the 3.4.7 hook-pollution patch)moderate
DOMPurify: IN_PLACE hook removal leaves a detached subtree executable, causing XSSmoderate
Only included vulnerabilities with severity moderate or higher.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/dompurify 3.4.8 🟢 9.8
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
Maintained🟢 1030 commit(s) and 14 issue activity found in the last 90 days -- score normalized to 10
Dependency-Update-Tool🟢 10update tool detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Security-Policy🟢 10security policy file detected
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Packaging⚠️ -1packaging workflow not detected
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies🟢 10all dependencies are pinned
CII-Best-Practices🟢 7badge detected: Silver
SAST🟢 10SAST tool is run on all commits
License🟢 10license file detected
Vulnerabilities🟢 100 existing vulnerabilities detected
Fuzzing🟢 10project is fuzzed
Signed-Releases🟢 105 out of the last 5 releases have a total of 10 signed artifacts.
Branch-Protection🟢 8branch protection is not maximal on development and all release branches
CI-Tests🟢 1030 out of 30 merged PRs checked by a CI test -- score normalized to 10
Contributors🟢 10project has 42 contributing companies or organizations
npm/marked 14.0.0 🟢 7.4
Details
CheckScoreReason
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Maintained🟢 1030 commit(s) and 11 issue activity found in the last 90 days -- score normalized to 10
Code-Review🟢 7Found 14/18 approved changesets -- score normalized to 7
Security-Policy🟢 10security policy file detected
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
Fuzzing⚠️ 0project is not fuzzed
License🟢 9license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Packaging🟢 10packaging workflow detected
npm/monaco-editor 0.56.0 🟢 7.8
Details
CheckScoreReason
Maintained🟢 1030 commit(s) out of 30 and 1 issue activity out of 30 found in the last 90 days -- score normalized to 10
Code-Review🟢 10all last 30 commits are reviewed through GitHub
CII-Best-Practices⚠️ 0no badge detected
Vulnerabilities🟢 10no vulnerabilities detected
Signed-Releases⚠️ -1no releases found
Branch-Protection🟢 8branch protection is not maximal on development and all release branches
Security-Policy🟢 10security policy file detected
License🟢 10license file detected
Packaging⚠️ -1no published package detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0non read-only tokens detected in GitHub workflows
Binary-Artifacts🟢 10no binaries found in the repo
Fuzzing⚠️ 0project is not fuzzed
Dependency-Update-Tool🟢 10update tool detected
Pinned-Dependencies🟢 7dependency not pinned by hash detected -- score normalized to 7
npm/ws 8.21.3 🟢 5.5
Details
CheckScoreReason
Code-Review⚠️ 0Found 1/29 approved changesets -- score normalized to 0
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Maintained🟢 1018 commit(s) and 4 issue activity found in the last 90 days -- score normalized to 10
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Security-Policy🟢 10security policy file detected
Packaging⚠️ -1packaging workflow not detected
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Signed-Releases⚠️ -1no releases found

Scanned Files

  • package-lock.json

… with 2 updates

Bumps the production-minor-patch group with 2 updates in the / directory: [monaco-editor](https://github.com/microsoft/monaco-editor) and [ws](https://github.com/websockets/ws).


Updates `monaco-editor` from 0.52.2 to 0.56.0
- [Release notes](https://github.com/microsoft/monaco-editor/releases)
- [Changelog](https://github.com/microsoft/monaco-editor/blob/main/CHANGELOG.md)
- [Commits](microsoft/monaco-editor@v0.52.2...v0.56.0)

Updates `ws` from 8.21.0 to 8.21.3
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.21.0...8.21.3)

---
updated-dependencies:
- dependency-name: monaco-editor
  dependency-version: 0.56.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: production-minor-patch
- dependency-name: ws
  dependency-version: 8.21.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: production-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/production-minor-patch-90d27840f4 branch from 185cbe6 to 42ade93 Compare August 14, 2026 19:04
@eneskirca

Copy link
Copy Markdown
Owner

Blocked — and the build break is the smaller of the two problems

I verified this locally against a real npm ci + npm run build, not just CI.

1. Security: monaco-editor 0.56.0 drags in a vulnerable DOMPurify

This is the blocking issue. monaco-editor@0.56.0 declares "dompurify": "3.4.8" as an exact pin, and 3.4.8 currently carries two open moderate advisories:

  • GHSA-cmwh-pvxp-8882 — permanent ALLOWED_ATTR pollution via setConfig(), bypassing the hook clone-guard (an incomplete fix of the 3.4.7 hook-pollution patch)
  • GHSA-55q2-fjhq-7xh7IN_PLACE hook removal leaves a detached subtree executable, causing XSS

That is what the Dependency review check is failing on (fail-on-severity: moderate), and it is a correct failure. Monaco renders markdown in hovers and suggestion documentation inside our renderer process, so this is not a theoretical dependency-graph nit.

Because monaco pins the exact version, bumping DOMPurify needs an overrides entry in package.json rather than a lockfile refresh — and that should wait until monaco itself ships a release on a patched 3.4.x.

Recommendation: hold the monaco bump until upstream moves off 3.4.8.

2. The build break from #37 is back, and the cause is now known

npm run build fails:

[vite]: Rollup failed to resolve import "monaco-editor/esm/vs/editor/editor.worker?worker"
from "src/renderer/editor/monaco-setup.ts".

Root cause: 0.56 added an exports map to its package.json:

"exports": {
  ".":      { "import": "./esm/vs/index.js", "require": "./min/vs/index.js" },
  "./*.js": "./esm/vs/*.js",
  "./*":    "./esm/vs/*.js"
}

Our five worker imports still use the pre-exports deep path, so monaco-editor/esm/vs/editor/editor.worker now resolves to ./esm/vs/esm/vs/editor/editor.worker.js — which does not exist. The fix is to drop the esm/vs/ prefix in src/renderer/editor/monaco-setup.ts:

-import EditorWorker from 'monaco-editor/esm/vs/editor/editor.worker?worker'
-import JsonWorker   from 'monaco-editor/esm/vs/language/json/json.worker?worker'
-import CssWorker    from 'monaco-editor/esm/vs/language/css/css.worker?worker'
-import HtmlWorker   from 'monaco-editor/esm/vs/language/html/html.worker?worker'
-import TsWorker     from 'monaco-editor/esm/vs/language/typescript/ts.worker?worker'
+import EditorWorker from 'monaco-editor/editor/editor.worker?worker'
+import JsonWorker   from 'monaco-editor/language/json/json.worker?worker'
+import CssWorker    from 'monaco-editor/language/css/css.worker?worker'
+import HtmlWorker   from 'monaco-editor/language/html/html.worker?worker'
+import TsWorker     from 'monaco-editor/language/typescript/ts.worker?worker'

I applied exactly that locally and the build passes, with all five worker chunks emitted (editor.worker-*.js, json.worker-*.js, css.worker-*.js, html.worker-*.js, ts.worker-*.js). Two notes for whoever lands this later:

  • The "." entry changed from esm/vs/editor/editor.main.js to esm/vs/index.js. I diffed them — same 166 lines, only relative paths shifted — so the main entry is equivalent.
  • The lazy monaco-setup chunk grows 6.35 MB → 7.58 MB (0.56 pulls in an LSP-client layer). boot is unchanged at ~2.03 MB, so cold start is unaffected; it is the file-editor chunk that pays.

Note the new import specifiers only work on ≥0.56, so that change has to land in the same commit as the version bump.

3. ws 8.21.0 → 8.21.3 is being held hostage

The other half of this group PR is a harmless ws patch bump that has nothing to do with monaco. It would be worth splitting ws out so it can land now while monaco waits.


Not merging. Leaving open so the dependency-review signal stays visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant