chore(deps): bump the production-minor-patch group across 1 directory with 2 updates - #175
Conversation
Dependency ReviewThe following issues were found:
Vulnerabilitiespackage-lock.jsonOnly included vulnerabilities with severity moderate or higher. OpenSSF Scorecard
Scanned Files
|
… with 2 updates Bumps the production-minor-patch group with 2 updates in the / directory: [monaco-editor](https://github.com/microsoft/monaco-editor) and [ws](https://github.com/websockets/ws). Updates `monaco-editor` from 0.52.2 to 0.56.0 - [Release notes](https://github.com/microsoft/monaco-editor/releases) - [Changelog](https://github.com/microsoft/monaco-editor/blob/main/CHANGELOG.md) - [Commits](microsoft/monaco-editor@v0.52.2...v0.56.0) Updates `ws` from 8.21.0 to 8.21.3 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.21.0...8.21.3) --- updated-dependencies: - dependency-name: monaco-editor dependency-version: 0.56.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: production-minor-patch - dependency-name: ws dependency-version: 8.21.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: production-minor-patch ... Signed-off-by: dependabot[bot] <support@github.com>
185cbe6 to
42ade93
Compare
Blocked — and the build break is the smaller of the two problemsI verified this locally against a real 1. Security: monaco-editor 0.56.0 drags in a vulnerable DOMPurifyThis is the blocking issue.
That is what the Because monaco pins the exact version, bumping DOMPurify needs an Recommendation: hold the monaco bump until upstream moves off 3.4.8. 2. The build break from #37 is back, and the cause is now known
Root cause: 0.56 added an "exports": {
".": { "import": "./esm/vs/index.js", "require": "./min/vs/index.js" },
"./*.js": "./esm/vs/*.js",
"./*": "./esm/vs/*.js"
}Our five worker imports still use the pre- -import EditorWorker from 'monaco-editor/esm/vs/editor/editor.worker?worker'
-import JsonWorker from 'monaco-editor/esm/vs/language/json/json.worker?worker'
-import CssWorker from 'monaco-editor/esm/vs/language/css/css.worker?worker'
-import HtmlWorker from 'monaco-editor/esm/vs/language/html/html.worker?worker'
-import TsWorker from 'monaco-editor/esm/vs/language/typescript/ts.worker?worker'
+import EditorWorker from 'monaco-editor/editor/editor.worker?worker'
+import JsonWorker from 'monaco-editor/language/json/json.worker?worker'
+import CssWorker from 'monaco-editor/language/css/css.worker?worker'
+import HtmlWorker from 'monaco-editor/language/html/html.worker?worker'
+import TsWorker from 'monaco-editor/language/typescript/ts.worker?worker'I applied exactly that locally and the build passes, with all five worker chunks emitted (
Note the new import specifiers only work on ≥0.56, so that change has to land in the same commit as the version bump. 3.
|
Bumps the production-minor-patch group with 2 updates in the / directory: monaco-editor and ws.
Updates
monaco-editorfrom 0.52.2 to 0.56.0Release notes
Sourced from monaco-editor's releases.
... (truncated)
Changelog
Sourced from monaco-editor's changelog.
... (truncated)
Commits
13f0c87Bump websocket-driver from 0.7.4 to 0.7.5 in /website (#5392)b5f23a3Merge pull request #5396 from microsoft/hediet/b/release-0.56.09d053abImprove Monaco Editor 0.56.0 changelog0ba33d0Release Monaco Editor 0.56.06d961b1Bump websocket-driver from 0.7.4 to 0.7.5 in /samples (#5385)d8c9ff0Removes leftover debugger statements. (#5379)59285abfixes pipeline (#5376)aaf58dbBump webpack-dev-server from 5.2.4 to 5.2.5 in /samples (#5374)d8ac38eBump webpack-dev-server from 5.2.4 to 5.2.5 in /website (#5373)874af57Bump undici from 7.24.7 to 7.28.0 (#5371)Updates
wsfrom 8.21.0 to 8.21.3Release notes
Sourced from ws's releases.
Commits
c791e70[dist] 8.21.3e97a20e[fix] Reject offers withclient_max_window_bitsbelow config787ebf2[dist] 8.21.2b4d62ebRevert "[ci] Trust Coveralls Homebrew tap"e4bb883[security] Use GitHub PVR as main reporting channel2eb3be0[test] Skip test on Node.js versions where it does not applyae1de54[dist] 8.21.18e9511b[ci] Trust Coveralls Homebrew tapf197ac6[fix] Lower default values ofmaxBufferedChunksandmaxFragments8df8265[ci] Update actions/checkout action to v7