chore(deps-dev): bump vite from 7.3.6 to 8.2.1 - #177
dependabot[bot] wants to merge 2 commits into
Conversation
dependabot
Bot
added
dependencies
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 7.3.6 to 8.2.1. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v8.2.1/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 8.2.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
7481a6a to
c7f2262
Compare
Do not merge — hold for
|
| dep | vite 7 (baseline) | vite 8 + electron-vite 5 |
|---|---|---|
electron |
external | external (hardcoded) |
node-pty |
external | external (hardcoded) |
electron-updater |
external | inlined |
ws |
external | inlined |
tweetnacl |
external | inlined |
smart-whisper |
external | inlined into a new out/main/chunks/ |
out/main/index.js goes 1,032,116 → 1,954,353 bytes (+89%), 210 → 390 modules.
That is a runtime break, not a size regression. smart-whisper and node-pty are our two asarUnpack / electron-rebuild native modules — bundling smart-whisper's JS breaks its .node binding resolution inside asar — and electron-updater inlined into asar breaks its app-update.yml resolution. A "just add --legacy-peer-deps to CI" fix would have produced a green build that ships a broken auto-updater and broken dictation. Worth remembering the next time a dependency bump only fails at install.
The combination that does work
I built vite 8.2.1 + electron-vite@6.0.0-beta.1 + @vitejs/plugin-react@6.0.5 locally:
- installs with no
--legacy-peer-deps npm run typecheckpassesnpm run buildpasses with zero warnings, 211 modules, no straychunks/dir, and the externals list is exactly the baseline set again — electron-vite 6 fixes the externalization bug- full
npx vitest runmatches the baseline failure list exactly; zero regressions from vite 8 or vitest-on-vite-8
Output changes, all benign: out/main/index.js +21.5% (rolldown CJS interop overhead), renderer total −7.4% (ts.worker −14% from the oxc minifier). Chunk hashes all change; I found nothing hardcoding them.
electron.vite.config.ts itself needs no changes — rolldown accepted rollupOptions.external including the /^node-pty/ RegExp. Only two soft deprecations, both from the React plugin (esbuild → oxc, optimizeDeps.rollupOptions → rolldownOptions).
Recommendation
Hold until electron-vite@6.0.0 stable ships. At that point this is a verified 3-line package.json change (vite ^8, electron-vite ^6, @vitejs/plugin-react ^6). Leaving the PR open as a tracker is fine; merging it in any form today is not.
|
A newer version of vite exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
Thanks — holding on Vite 8 for now. Our electron-vite 5 peer range is Vite ≤7 (Vite 8 support only lands in electron-vite 6, currently 6.0.0-beta), and @vitejs/plugin-react 4.x is also ≤7. Forced through, typecheck/test/build/dev all pass (only deprecation warnings), so the migration itself looks smooth — but living outside the peer range isn't worth it. This will come back as a deliberate three-way bump (Vite 8 + electron-vite 6 + plugin-react ≥6) once electron-vite 6 is stable. Closing so it doesn't sit stale; Dependabot will re-open when a newer Vite 8 patch appears. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
1 participant
Bumps vite from 7.3.6 to 8.2.1.
Release notes
Sourced from vite's releases.
... (truncated)
Changelog
Sourced from vite's changelog.
... (truncated)
Commits
4216158release: v8.2.1fddf4eafix(server): use a random port when port is 0 (#23158)de041a7fix(css): don't re-run lightningcss visitor during minify (fix #23146) (#23147)15f0307fix(build): make client chunkImportMap work withsharedPlugins: true(#23184)c2155fetest(bundled-dev): enable sourcemap playgrounds (#23080)ef02435docs(build): fix incomplete@defaultfor build.minify (#23177)eac0cc8fix(bundled-dev): inject client script tag before chunk scripts (#23161)23b8a08refactor(bundled-dev): avoid injecting server values in the bundle (#22967)e72036erefactor(bundled-dev): remove rolldown lazy stub module workaround (#23129)14454fdfix(deps): update all non-major dependencies (#23136)