reverse_tunnels: intercept RPING on upstream reverse connections#43666
Open
aakugan wants to merge 1 commit intoenvoyproxy:mainfrom
Open
reverse_tunnels: intercept RPING on upstream reverse connections#43666aakugan wants to merge 1 commit intoenvoyproxy:mainfrom
aakugan wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: aakugan <aakashganapathy2@gmail.com>
e5dd925 to
f248e1e
Compare
Contributor
|
@aakugan can you detail a little more on the steps leading to this issue? Is this a race between upstream receiving a RPONG in plaintext from downstream, after having sent a data request on a HTTP/2 stream? |
Contributor
Author
|
Yes @basundhara-c that is correct under heavy load / latency we observed that the connection may get upgraded ie PRI... was sent and the codec is waiting for the settings frame before the downstream RPONG is received which is then directly passed to the client_codec_ causing this issue. |
Contributor
|
/assign @botengyao |
basundhara-c
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message
Intercept RPING on upstream reverse connections
Additional Description
If a RPING is sent and then the connection is upgraded to http2 via the conn pool the downstream reverse connection io handle's rping response causes a 502 protocol error.
More specifically: Remote peer returned unexpected data while we expected SETTINGS frame
Additional logs:
The Alert was a custom log line added by me for easier debugging.
Its better for both the downstream and upstream rc io handles to share a common read implementation.
Testing
Unit tests.
Additionally, manually validated the example in the docs which also works after the change.