router: fix direct_response Content-Type#43694
Merged
wbpcode merged 4 commits intoenvoyproxy:mainfrom Mar 5, 2026
Merged
Conversation
ravenblackx
previously approved these changes
Mar 3, 2026
Contributor
ravenblackx
left a comment
ravenblackx
left a comment
There was a problem hiding this comment.
Looks like a good fix to me, thanks!
Signed-off-by: garima-uttam <garimauttam@ibm.com>
Signed-off-by: garima-uttam <garimauttam@ibm.com>
garimauttam
force-pushed
the
fix/direct-response-content-type
branch
from
0d1f177 to
a365b8e
Compare
Contributor
|
In general please try to avoid force pushing as it makes reviewing more work - append commits rather than amending. Autoformatter now requires a fix, see this CI run. |
ravenblackx
requested changes
Mar 3, 2026
Signed-off-by: garima-uttam <garimauttam@ibm.com>
Contributor
|
/retest |
ravenblackx
approved these changes
Mar 4, 2026
Contributor
|
/assign-from @envoyproxy/senior-maintainers |
|
@envoyproxy/senior-maintainers assignee is @phlax |
Member
|
lgtm, but probs im not the senior maintainer needed for sign off /retest |
Contributor
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
direct_responseusesbody_format.content_type, the response always returnsContent-Type: text/plain. The field was parsed from proto but never stored or applied.Fix
responseContentType()pure virtual toDirectResponseEntrycontent_typefrombody_formatinRouteEntryImplBase(explicit → JSON default → empty)sendLocalReplymodify_headerslambdaTests added
RouteConfigurationV2.DirectResponseBodyFormatContentType— all 4 content-type casesRouterTest.DirectResponseWithBodyFormatContentType— end-to-endtext/htmlheaderRouterTest.DirectResponseWithBodyFormatNoContentType— no override when emptyFixes #43680