http: wire ConnectionLifetimeCallbacks into pool connection events#43702
Open
aakugan wants to merge 1 commit intoenvoyproxy:mainfrom
Open
http: wire ConnectionLifetimeCallbacks into pool connection events#43702aakugan wants to merge 1 commit intoenvoyproxy:mainfrom
aakugan wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: aakugan <aakashganapathy2@gmail.com>
ggreenway
reviewed
Mar 3, 2026
Member
ggreenway
left a comment
ggreenway
left a comment
There was a problem hiding this comment.
Added a couple of drive-by comments
| } | ||
|
|
||
| protected: | ||
| OptRef<ConnectionLifetimeCallbacks> callbacks_; |
Member
There was a problem hiding this comment.
Move all implementation and data out of the interface and into the implementation
|
|
||
| // Override to provide the lifetimeCallbacks. | ||
| void onEvent(Network::ConnectionEvent event) override { | ||
| if (event == Network::ConnectionEvent::Connected || |
Member
There was a problem hiding this comment.
Move implementation into .cc file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message
http: wire ConnectionLifetimeCallbacks into pool connection events
Description
Wires up the
ConnectionLifetimeCallbacksinterface that is there but is not connected to actual connection events from what I see at least. The cluster manager now passes the LB's callbacks into each HTTP pool at creation time, andMultiplexedActiveClientBasefires them on Connected, Close, and GOAWAY events.Primary motivation: allows the reverse tunnel cluster's LB to detect GOAWAY and report it to the tunnel reporter (raw example). Also applicable to DFP clusters for connection coalescing awareness from what I see.
Risk Level
Should be low. Additive-only changes to production code. Callbacks are no-ops unless explicitly set by the LB. No behavior change for existing clusters.
Testing
MultiplexedActiveClientBase.setLifetimeCallbacksis called on pool creation.Docs Changes
N/A
Release Notes
N/A