tidy: enforce and apply C++20 container contains() - #46660
Merged
jwendell merged 1 commit intoAug 13, 2026
Conversation
Enable the `readability-container-contains` clang-tidy check so that `count(k)`/`find(k) != end()` membership tests are flagged going forward, and apply the `.contains()` conversion across the non-extensions code (the extensions tree was cleaned up separately). Readability cleanup with no behavior change. Signed-off-by: Jonh Wendell <jwendell@redhat.com>
jwendell
force-pushed
the
extensions-contains-enforce-clang-tidy
branch
from
August 12, 2026 12:29
4a39176 to
71863ae
Compare
jwendell
marked this pull request as ready for review
August 12, 2026 12:53
jwendell
requested review from
ggreenway,
mattklein123 and
wbpcode
as code owners
August 12, 2026 12:53
jwendell
enabled auto-merge (squash)
August 12, 2026 14:23
nezdolik
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the
readability-container-containsclang-tidy check so thatcount(k)/find(k) != end()membership tests are flagged going forward, and apply the.contains()conversion across the non-extensions code (the extensions tree was cleaned up separately).Readability cleanup with no behavior change.