Allow connection teardown even when cert selection is not yet complete - #46676
Draft
etruong42 wants to merge 1 commit into
Draft
Allow connection teardown even when cert selection is not yet complete#46676etruong42 wants to merge 1 commit into
etruong42 wants to merge 1 commit into
Conversation
Contributor
Author
|
See at https://github.com/envoyproxy/envoy/actions/runs/31535461828/job/93925722829 |
Change-Id: I155b874accd54affa65bfa0b744ff99154060570 Signed-off-by: Ethan Truong <ethantruong@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#45755 allowed the socket state to transition to
ShutdownSentbefore cert selection is complete (as intended). However, this could causeENVOY_BUGto be thrown whenSslSocket::onAsynchronousCertificateSelectionComplete()is invoked. This patch updatesSslSocket::onAsynchronousCertificateSelectionCompleteto allow this socket state which is consistent with the implementation ofSslSocket::onAsynchronousCertValidationCompleteand avoids theENVOY_BUGin the case of valid states such asShutdownSent.Change-Id: I155b874accd54affa65bfa0b744ff99154060570
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]