Add extension point to OpenTelemetry tracer for custom exporters. - #46679
Open
jakebennert wants to merge 12 commits into
Open
Add extension point to OpenTelemetry tracer for custom exporters.#46679jakebennert wants to merge 12 commits into
jakebennert wants to merge 12 commits into
Conversation
Signed-off-by: Jake Bennert <jakebennert@google.com>
Signed-off-by: Jake Bennert <jakebennert@google.com>
Signed-off-by: Jake Bennert <jakebennert@google.com>
Signed-off-by: Jake Bennert <jakebennert@google.com>
Signed-off-by: Jake Bennert <jakebennert@google.com>
Signed-off-by: Jake Bennert <jakebennert@google.com>
Signed-off-by: Jake Bennert <jakebennert@google.com>
Signed-off-by: Jake Bennert <jakebennert@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Jake Bennert <jakebennert@google.com>
Signed-off-by: Jake Bennert <jakebennert@google.com>
Signed-off-by: Jake Bennert <jakebennert@google.com>
Signed-off-by: Jake Bennert <jakebennert@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message
Added support for custom exporters in the OpenTelemetry tracer.
In implementing this feature, I also changed some existing code in opentelemetry_tracer_impl.cc to make it more thread safe, such as moving the instantiation of the gRPC client factory out of the worker threads and into the main thread. This means that if the factory creation returns an error, it won't crash the worker thread, and thereby the whole Envoy proxy.
Additional Description
AI was used to generate the code and tests in this PR. I have reviewed – and fully understand – the code.
Risk Level
Low
Testing
I've added unit tests testing both the control plane and data plane code flows.
Docs Changes
None required
Release Notes
Added a changelog under new_features (area: tracing)
Platform Specific Features
None