Skip to content

reverse_tunnel: reject new streams during listener drain - #47446

Closed
AntonKanug wants to merge 1 commit into
envoyproxy:mainfrom
AntonKanug:antonk/reverse-tunnel-strict-drain
Closed

AntonKanug wants to merge 1 commit into
envoyproxy:mainfrom
AntonKanug:antonk/reverse-tunnel-strict-drain

Conversation

@AntonKanug

@AntonKanug AntonKanug commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Continued in #49361.

Stop reverse-tunnel initiators from creating or replacing tunnels when their listener starts draining, including pending handshakes. Close unused tunnels with drain-aware HCM enabled, while preserving replacement behavior for in-place filter-chain updates and normal connection rotation.

Preserve the current METADATA and GOAWAY schedule. Once GOAWAY arrives, responders exclude initiators whose remaining tunnels are all draining from new-stream selection while existing streams finish within the listener drain window.

Updated with AI assistance.

@repokitteh-read-only

Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #47446 was opened by AntonKanug.

see: more, trace.

@AntonKanug
AntonKanug force-pushed the antonk/reverse-tunnel-strict-drain branch 2 times, most recently from 3fbedcf to 4d67d09 Compare September 14, 2026 18:59
@AntonKanug
AntonKanug marked this pull request as ready for review September 14, 2026 19:56
@repokitteh-read-only

Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @mattklein123
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #47446 was ready_for_review by AntonKanug.

see: more, trace.

@AntonKanug
AntonKanug force-pushed the antonk/reverse-tunnel-strict-drain branch from 4d67d09 to 4456fa8 Compare September 14, 2026 20:07
Signed-off-by: Anton Kanugalawattage <antonk@palantir.com>
@AntonKanug
AntonKanug force-pushed the antonk/reverse-tunnel-strict-drain branch from 4456fa8 to 082dbd5 Compare September 16, 2026 20:24
@basundhara-c

Copy link
Copy Markdown
Contributor

/assign basundhara-c

@AntonKanug

Copy link
Copy Markdown
Contributor Author

/retest

@basundhara-c

Copy link
Copy Markdown
Contributor

@agrawroh can you have a final look?

@basundhara-c

Copy link
Copy Markdown
Contributor

/wait

@basundhara-c

Copy link
Copy Markdown
Contributor

/assign aakugan

@repokitteh-read-only

Copy link
Copy Markdown

aakugan cannot be assigned to this issue.

🐱

Caused by: a #47446 (comment) was created by @basundhara-c.

see: more, trace.

@aakugan

aakugan commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

/assign aakugan

@repokitteh-read-only

Copy link
Copy Markdown

aakugan is not allowed to assign users.

🐱

Caused by: a #47446 (comment) was created by @aakugan.

see: more, trace.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale stalebot believes this issue/PR has not been touched recently label Nov 8, 2026
@github-actions

Copy link
Copy Markdown

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api stale stalebot believes this issue/PR has not been touched recently waiting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants